Skip to content

Use rolldown for bundling#621

Merged
Andarist merged 2 commits into
mainfrom
rolldown
May 15, 2026
Merged

Use rolldown for bundling#621
Andarist merged 2 commits into
mainfrom
rolldown

Conversation

@bluwy
Copy link
Copy Markdown
Member

@bluwy bluwy commented May 15, 2026

No description provided.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 15, 2026

⚠️ No Changeset found

Latest commit: 78cb025

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@socket-security
Copy link
Copy Markdown

socket-security Bot commented May 15, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedrolldown@​1.0.1951007899100
Addedvitest@​4.1.6961007999100

View full report

Comment thread pnpm-workspace.yaml Outdated
Comment on lines +6 to +9
overrides:
lightningcss: '-' # we do not bundle any css
postcss: '-' # we do not bundle any css
rolldown: $rolldown # use same version for vitest's rolldown
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skip installing lightningcss and postcss as we don't have ay css files. Saves about 11MB to install.

Also set a consistent rolldown version here to prevent duplicate because vite is gated to an older version because of minimumReleaseAge 7 days :(

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I installed the new ones with some help from minimumReleaseAgeExclude

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I didn't went with it initially because we'd have to constantly update or maintain the versions, but I'm fine with anything for now.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, but at least we have a longer cooldown period and we still can explicitly opt into trusting certain packages/versions. We just should periodically prune this list. I think the tradeoff is fine.

@Andarist
Copy link
Copy Markdown
Member

before

wc -c dist/index.js # 1195129 
gzip -c dist/index.js | wc -c # 368726

after

wc -c dist/index.js # 1228159 
gzip -c dist/index.js | wc -c # 359640 

Interestingly, this is a 3~% regression for the size of the bundle BUT a 3~% improvement for a gzipped one 😅

@Andarist Andarist enabled auto-merge May 15, 2026 19:01
@Andarist Andarist added this pull request to the merge queue May 15, 2026
Merged via the queue into main with commit c13a489 May 15, 2026
6 checks passed
@Andarist Andarist deleted the rolldown branch May 15, 2026 19:03
@bluwy
Copy link
Copy Markdown
Member Author

bluwy commented May 15, 2026

Yeah I think rolldown/oxc still have some work to get on par with terser for minifying, but it's not too much and we get much simpler tooling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants