feat(materials): add gitleaks json material type support #2693
+519
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sylwester Piskozub <sylwesterpiskozub@gmail.com>
Piskoo
changed the title
migmartri
reviewed
Jan 30, 2026
| } | ||
|
|
||
| var findings []GitleaksFinding | ||
| if err = json.Unmarshal(data, &findings); err != nil { |
Member
There was a problem hiding this comment.
what kind of validation are we making here to make sure it's a gitleaks report?
Do we check the tool? Does the json output have any openAPI spec published? I believe we make spec validations in some of those materials.
Collaborator
Author
There was a problem hiding this comment.
We can't check the tool, the report is returned as an json array [{},{}] there's no tool information attached. There's no offical schema published. I decided to do validation similar to GHAS_SECRET_SCAN where we unmarshal and then check for a required field
migmartri
reviewed
Jan 30, 2026
Signed-off-by: Sylwester Piskozub <sylwesterpiskozub@gmail.com>
Piskoo
changed the title
javirln
previously approved these changes
Jan 30, 2026
Signed-off-by: Sylwester Piskozub <sylwesterpiskozub@gmail.com>
javirln
approved these changes
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new
GITLEAKS_JSONmaterial type. JSON report returned bygitleaksis an array of objects, for validation we unmarshal each finding and then check forfingerprintfieldCloses #2694