SecondaryNav component#581
Conversation
|
770317a to
19f5f9b
Compare
Fixes a silly linting warning. th / table headers need to live inside a table row
19f5f9b to
aeb5aff
Compare
|
@flacoman91 |
|
@flacoman91 Secondary navigation
I noticed that these layout and grid components include "Usage" sections that don't follow the pattern of other DSR components. I'd like to consider how we can include this information without deviating from the top level presentation for each component. What would you think of moving it to appear after the component variants? HeroI missed this earlier when I was reviewing the hero, that we added a sentence to the Storybook page that also deviates from the standard template. The text reads: "This component supports illustration, photograph (overlay), and knockout variants only — not the DS jumbo or 50/50 patterns." Can we move this text either to the bottom of the Storybook page OR just indicate it in the code view? And, can we change the wording to:
|
|
@flacoman91 |
|
@flacoman91
Screenshots
|
|
|
@flacoman91 |
Looks like there was an issue with the way the iframe loads it. the iframe loads an iframe and it was losing the font, I updated it and it should look good now. |
|
@flacoman91 - I don't think this has been fixed yet?
|
|










This breaks out secondary nav component work out of #560 for a more focused PR
Addresses: #557