ENT-14061: Reproducible masterfiles builds with container scripts#2271
Merged
Conversation
|
Thanks for submitting a PR! Maybe @craigcomstock can review this? |
a652514 to
20d9a56
Compare
Add a build step to build-in-container-inner.sh that runs "make dist" and "make tar-package" on the masterfiles repo, dropping both the source and package tarballs into /output alongside the platform packages. Widen the output listing glob in build-in-container.py to *.tar.gz so the source tarball is reported too. Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Without the zip extension Composer's --prefer-dist install fails to unpack zip archives, causing the 03-mission-portal-deps build step to error out. Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Just ignore the role option for community builds. Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
ebd4097 to
63d54eb
Compare
olehermanse
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key changes for reproducible builds is in cfengine/masterfiles#3166. However, the version of tar must be pinned. Hence, we should build it in the container script.
Ticket: ENT-14061
TODO:
Checksums between community and enterprise build: