Little improvements over origin accessor and writer deprecation warnings#487
Merged
santiagorodriguez96 merged 2 commits intomasterfrom Oct 23, 2025
Merged
Conversation
santiagorodriguez96
changed the title
origin setter and getter deprecation warningsorigin accessor and writer deprecation warnings
santiagorodriguez96
requested review from
joaquintomas2003 and
nicolastemciuc
lib/webauthn/relying_party.rb
Outdated
Comment on lines
+127
to
+129
| "DEPRECATION WARNING: `WebAuthn.origin` is deprecated and will return `nil` " \ | ||
| "when `WebAuthn.allowed_origins` contains more than one origin. " \ | ||
| "Please use `WebAuthn.allowed_origins` instead." |
Member
There was a problem hiding this comment.
IMO the word "will" makes it sound like it will return nil in the future, but it actually does that now, right?
This will make it clear to users of the gem that using `WebAuthn.origin` when setting multiple allowed origins will make the former return `nil`.
Make it clear that the method throwing the deprecation warning is the seter (`WebAuthn.origin=`)
santiagorodriguez96
force-pushed
the
sr--improve-deprecation-warnings
branch
from
d67049e to
477887f
Compare
santiagorodriguez96
changed the title
origin accessor and writer deprecation warningsorigin accessor and writer deprecation warnings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.