Apply theme-driven token derivation to every CardContainer#5474
Open
burieberry wants to merge 1 commit into
Open
Apply theme-driven token derivation to every CardContainer#5474burieberry wants to merge 1 commit into
burieberry wants to merge 1 commit into
Conversation
theme.css now ships the full semantic token contract with defaults, so the --boxel-* derivation that was gated behind @isThemed applies to all containers; themed cards differ only in the knob values their scoped stylesheet provides. @isThemed remains as a marker-class-only arg. Adjust the section-heading and subheading fallbacks (weight 500, line-height md/base) to match the legacy defaults in variables.css so unthemed cards render value-identically. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aa6e783056
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Contributor
Preview deploymentsHost Test Results 1 files 1 suites 2h 58m 42s ⏱️ Results for commit aa6e783. For more details on these errors, see this check. Realm Server Test Results 1 files 1 suites 11m 28s ⏱️ Results for commit aa6e783. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
theme.cssships the full semantic token contract with defaults that resolve to the legacy--boxel-*values, so the token derivation that was gated behind@isThemednow applies to every CardContainer — the rules move from.boxel-card-container--themedto.boxel-card-container. Themed cards differ only in the knob values their scoped theme stylesheet provides.@isThemedremains as a deprecated, marker-class-only arg (still stamps the--themedclass) so existing callers are unaffected.md/base) are aligned with the legacy defaults invariables.css, so unthemed cards render value-identical to before.