Change the host store to allow prefix RRI keys#5470
Draft
backspace wants to merge 2 commits into
Draft
Conversation
asURL's string branch normalized remote ids to URL form while its document branch returned data.id verbatim — which is canonical (prefix form for mapped realms) as served — so the two branches could key the same mapped-realm card under different spellings. Fold the string branch to the canonical spelling too: parse through the VN's URL machinery for normalization, then back to prefix form where a realm mapping exists. The render store's key normalization gets the same treatment. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Preview deploymentsHost Test Results 1 files ±0 1 suites ±0 2h 29m 24s ⏱️ - 6m 25s Results for commit d95b506. ± Comparison against earlier commit 1fca86d. Realm Server Test Results 1 files ±0 1 suites ±0 11m 45s ⏱️ +12s Results for commit d95b506. ± Comparison against earlier commit 1fca86d. |
The render store's cache-key normalization and its document-load normalization shared one helper, so folding keys to canonical spelling also changed the URL that loadCardDocument stamps onto the returned document's id. Split them: cache keys fold to the canonical spelling; load targets resolve to the real URL at the fetch boundary. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.