Skip to content

Only persist to published_realms after the realm has been successfully created, started, and indexed#3988

Merged
jurgenwerk merged 5 commits intomainfrom
cs-10154-published_realms-is-optimistically-updated-to-show-a-realm
Feb 16, 2026
Merged

Only persist to published_realms after the realm has been successfully created, started, and indexed#3988
jurgenwerk merged 5 commits intomainfrom
cs-10154-published_realms-is-optimistically-updated-to-show-a-realm

Conversation

@jurgenwerk
Copy link
Contributor

@jurgenwerk jurgenwerk commented Feb 12, 2026

This avoids updating the published_realms record before the needed operations for publishing are done.

@jurgenwerk jurgenwerk marked this pull request as ready for review February 12, 2026 12:43
@jurgenwerk jurgenwerk requested a review from Copilot February 12, 2026 12:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR changes the publish flow so the published_realms table is only updated/created after the published realm has been successfully created, started, and fully indexed—avoiding DB records that claim a realm is published before publish-time work finishes.

Changes:

  • Refactors publish logic to track publishedRealmId separately and avoid persisting published_realms data until after realm.start() and realm.fullIndex().
  • Updates the JSON:API response to use the computed publishedRealmId and request URLs rather than values read back from published_realms.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 31aca0d996

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@github-actions
Copy link

github-actions bot commented Feb 12, 2026

Host Test Results

    1 files  ±  0      1 suites  ±0   1h 39m 12s ⏱️ + 4m 40s
1 838 tests +110  1 825 ✅ +111  13 💤 ±0  0 ❌ ±0 
1 853 runs  +111  1 840 ✅ +113  13 💤 ±0  0 ❌  - 1 

Results for commit 6884c08. ± Comparison against base commit fcf29c5.

♻️ This comment has been updated with latest results.

@jurgenwerk jurgenwerk changed the base branch from cs-10140-expected-open-graph-tags-are-missing to main February 13, 2026 08:47
@jurgenwerk jurgenwerk merged commit 62fbf5e into main Feb 16, 2026
171 of 174 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants