Implement the new design for card search results#3986
Merged
Conversation
Preview deployments |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d315fce1c3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
packages/host/app/components/search-sheet/search-sheet-content.gts
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request implements a new design for card search results in the host application. The changes refactor the search sheet component to use a section-based layout with enhanced visual organization and improved user experience.
Changes:
- Introduced section-based search results with headers showing realm information and focus controls
- Extracted search logic into a dedicated
PrerenderedSearchResourcewith live realm update support - Added view toggles (grid/strip) and sort options for search results
- Implemented progressive disclosure with "Show more" functionality and display limits
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/host/app/resources/prerendered-search.ts | New resource managing prerendered card search with live realm subscriptions |
| packages/host/app/lib/realm-utils.ts | New utility functions for normalizing realm URLs and resolving card realms |
| packages/host/app/components/search-sheet/section-header.gts | New component for search section headers with realm info and "Show only" toggle |
| packages/host/app/components/search-sheet/search-sheet-content.gts | New component managing search content, sections, and state |
| packages/host/app/components/search-sheet/search-result-section.gts | New component rendering individual search result sections (realm, URL, recents) |
| packages/host/app/components/search-sheet/search-result-header.gts | New component for search result header with summary, view selector, and sort dropdown |
| packages/host/app/components/search-sheet/constants.ts | New constants file defining display limits, view options, and sort options |
| packages/host/app/components/search-sheet/results-section.gts | Modified to export SearchResult class and add displayRealmName support |
| packages/host/app/components/search-sheet/index.gts | Refactored to use SearchSheetContent component and updated click-outside selector |
| packages/host/app/components/prerendered-card-search.gts | Refactored to use PrerenderedSearchResource instead of inline search logic |
| packages/host/app/components/search-sheet/recent-cards-section.gts | Deleted - functionality moved to search-result-section |
| packages/host/app/components/search-sheet/card-url-results.gts | Deleted - functionality moved to search-sheet-content |
| packages/host/app/components/search-sheet/card-query-results.gts | Deleted - functionality moved to search-sheet-content |
| packages/host/tests/integration/components/operator-mode-ui-test.gts | Updated to use waitFor instead of click interactions for search results |
| packages/host/tests/integration/components/operator-mode-card-catalog-test.gts | Updated assertions for new search result design and added new tests for features |
| packages/host/tests/acceptance/interact-submode-test.gts | Updated search result assertions for new design |
| packages/host/tests/acceptance/freestyle-test.ts | Added setupAuthEndpoints to test setup |
| packages/host/tests/acceptance/code-submode/inspector-test.ts | Updated search label assertions with waitUntil for new design |
| packages/host/tests/acceptance/code-submode/card-playground-test.gts | Updated to use specific card selector instead of index-based selection |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/host/app/components/search-sheet/search-sheet-content.gts
Outdated
Show resolved
Hide resolved
packages/host/app/components/search-sheet/search-sheet-content.gts
Outdated
Show resolved
Hide resolved
packages/host/app/components/search-sheet/search-sheet-content.gts
Outdated
Show resolved
Hide resolved
packages/host/app/components/search-sheet/search-sheet-content.gts
Outdated
Show resolved
Hide resolved
burieberry
reviewed
Feb 13, 2026
Contributor
burieberry
left a comment
burieberry
left a comment
There was a problem hiding this comment.
Overall looks good. I think the query needs to run on the Recents too? I can implement my changes after your PR is merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2026-02-12.at.13.32.26.mov