docs: update README #35
Open
busehalis-sap wants to merge 2 commits into
Open
Conversation
… output, remove internal SAP links
busehalis-sap
changed the title
Schmarvinius
requested changes
Jun 29, 2026
Schmarvinius
left a comment
Schmarvinius
left a comment
Contributor
There was a problem hiding this comment.
It looks fine overall, but I think it is pretty huge for what it does.
Comment on lines
+358
to
+373
| ┌──────────────────────────────────────────────────────────────┐ | ||
| │ LOCAL NOTIFICATION (not sent to ANS) | ||
| ├──────────────────────────────────────────────────────────────┤ | ||
| │ From: noreply@notifications.local | ||
| │ To: your.email@example.com | ||
| │ Subject: Low Stock Alert: Wuthering Heights | ||
| │ Priority: HIGH | ||
| ├──────────────────────────────────────────────────────────────┤ | ||
| │ Stock: 12 remaining | ||
| │ | ||
| │ Notification Type: LowStockAlert | ||
| │ Parameters: | ||
| │ - bookTitle = Wuthering Heights | ||
| │ - author = Emily Brontë | ||
| │ - stock = 12 | ||
| └──────────────────────────────────────────────────────────────┘ |
Contributor
There was a problem hiding this comment.
Good idea but please use mermaid for something like this:
https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/creating-diagrams
Contributor
There was a problem hiding this comment.
Not sure which diagram is the correct one, maybe there is none
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates README to reflect recent code changes and removes SAP-internal references.
Changes
NotificationTemplateProviderServiceto the<excludes>block in the Maven setupLocalHandlerTemplateSensitive/TemplatePublicmapping notes from the annotation table