migrate Joi schemas and validation utils to Zod#465
Open
CKodidela wants to merge 1 commit intocameri:mainfrom
Open
migrate Joi schemas and validation utils to Zod#465CKodidela wants to merge 1 commit intocameri:mainfrom
CKodidela wants to merge 1 commit intocameri:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces the
joivalidation library withzodacross all schemas and validation utilities.Changed files:
src/schemas/base-schema.tshex/lowercase via regex, integer checks via.int(), customcreatedAtvia.refine(),tagSchemausingz.tuple().rest()src/schemas/event-schema.tsz.object().strict()replaces.unknown(false)src/schemas/filter-schema.ts.catchall()+.superRefine()handle dynamic#[a-z]tag filter keyssrc/schemas/message-schema.tsz.union()replacesalternatives().conditional();z.tuple().rest()withsuperRefinefor REQ boundssrc/utils/validation.tsvalidateSchema/attemptValidationrewritten against Zod APIsrc/adapters/web-socket-adapter.tserror name check updated fromValidationErrortoZodErrorRelated Issue
Closes #455
Motivation and Context
joiis a large runtime dependency.zodprovides equivalent validation with a TypeScript-first design, better typeinference, and a smaller footprint. All existing validation behaviour is preserved.
How Has This Been Tested?
All existing unit tests pass (381 passing) after updating schema spec files to work with Zod's error format. The 2
pre-existing failures in
settings.spec.tsare unrelated Windows path separator issues.Types of changes
Checklist: