Fix escaping "_" in bundle identifiers when gyp-to-cmake generates projects
#343
+11
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraenhansen
added
Apple 🍎
kraenhansen
force-pushed
the
kh/gyp-to-cmake-bundle-identifiers
branch
from
51f9e1c to
447becb
Compare
kraenhansen
changed the title
gyp-to-cmake generates projects
kraenhansen
force-pushed
the
kh/gyp-to-cmake-bundle-identifiers
branch
from
447becb to
bc1a139
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed the gyp-to-cmake was not escaping bundle ids correctly and I have no idea why that worked in the past 🙄