fix: restore interaction handler refactoring reverted by #245#254
Merged
thymikee merged 1 commit intocallstackincubator:mainfrom Mar 25, 2026
Merged
Conversation
…ubator#245 PR callstackincubator#248 refactored interaction.ts into a thin routing layer delegating to focused command modules. PR callstackincubator#245 (gesture telemetry overlays) unintentionally reverted get/is/scrollintoview back to inline implementations due to a stale branch. This restores the thin router from callstackincubator#248, adapted for callstackincubator#245's handleTouchInteractionCommands, and removes interaction-press.ts and interaction-fill.ts which were made dead code by callstackincubator#245's interaction-touch.ts.
Contributor
Author
|
Close #156 |
Contributor
There was a problem hiding this comment.
Pull request overview
Restores the post-#248 interaction handler architecture by returning src/daemon/handlers/interaction.ts to a thin router that delegates to per-command modules, while preserving #245’s gesture-telemetry-based touch command handling via interaction-touch.ts.
Changes:
- Refactors
interaction.tsback into a routing layer that delegatesget/is/scrollintoviewto dedicated modules and forwards touch commands tohandleTouchInteractionCommands. - Removes now-dead legacy implementations in
interaction-press.tsandinteraction-fill.ts(replaced byinteraction-touch.tsin #245).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/daemon/handlers/interaction.ts | Reinstates thin routing layer and wires touch/get/is/scroll handlers consistently. |
| src/daemon/handlers/interaction-press.ts | Deleted as dead code after touch handling moved to interaction-touch.ts. |
| src/daemon/handlers/interaction-fill.ts | Deleted as dead code after touch handling moved to interaction-touch.ts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
thymikee
approved these changes
Mar 25, 2026
Contributor
thymikee
left a comment
thymikee
left a comment
There was a problem hiding this comment.
whoa, thanks! that's a lot of leftovers removed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
interaction.tsinto a thin routing layer delegating to focused command modules (interaction-get.ts,interaction-is.ts,interaction-scroll.ts, etc.).get/is/scrollintoviewback to inline implementations due to a stale branch, while correctly introducinginteraction-touch.tsfor press/click/fill with gesture telemetry.handleTouchInteractionCommands, and removesinteraction-press.tsandinteraction-fill.tswhich became dead code when feat: add gesture telemetry recording overlays #245 replaced them withinteraction-touch.ts.Net: -950 lines (3 files changed, 28 insertions, 950 deletions).
Validation
pnpm typecheck— cleanpnpm test:unit— 870 pass, 0 failpnpm test:smoke— 8 pass, 0 failpnpm format— no changes to touched files