fix(tooltip): propagate press event object to onPress (#5003)#5009
Open
Shevilll wants to merge 1 commit into
Open
fix(tooltip): propagate press event object to onPress (#5003)#5009Shevilll wants to merge 1 commit into
Shevilll wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5003
On native,
Tooltip's internalhandlePresswas defined as() => { ...; props.onPress?.() }, which dropped theGestureResponderEventbefore forwarding to the wrapped child'sonPress. As a result, any child rendered inside aTooltipreceivedundefinedinstead of the press event object, breaking handlers that rely onevent.nativeEvent(e.g. reading touch coordinates).What changed
Tooltip.tsx:handlePressnow accepts theGestureResponderEventand threads it through toprops.onPress?.(e).utils.ts: widenedTooltipChildProps.onPressfrom() => voidto(e: GestureResponderEvent) => voidso the event type is correct end-to-end.No behavior change for the tooltip show/hide flow; this only restores the event argument that was previously swallowed.
onLongPress/hover handlers are unaffected.Why
Consumers expect a tooltip-wrapped element to behave like the element itself. Swallowing the press event silently breaks that contract on native.
Verification
onPress(verified it fails onmainwith "called with 0 arguments" and passes with this change).yarn jest src/components/__tests__/Tooltip.test.tsx→ 18/18 pass.yarn typescript→ passes.yarn linton changed files → passes.