fix: handle fragments in dialog actions#5008
Open
vivekjm wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Dialog.Actionsclones each action child to injectcompact,uppercase, and spacing props. When callers wrap actions in a fragment, React 19 warns because those props are applied toReact.Fragment, which only acceptskeyandchildren.This treats top-level fragments as transparent wrappers so their children still receive the dialog action props, while the fragment itself is not cloned.
Related issue
Fixes #4794
Test plan
yarn test src/components/__tests__/Dialog.test.tsx --runInBandyarn typescriptyarn lint-no-fix src/components/Dialog/DialogActions.tsx src/components/__tests__/Dialog.test.tsx(passes with an existing unrelated warning insrc/components/__tests__/TextInput.test.tsx)I also let the pre-commit hook run once. It ran lint, TypeScript, and the full Jest suite; the full suite failed in this sparse/source checkout because
src/babel/__tests__/index.jsexpectslib/mappings.json, which is not present without generating/buildinglib. The touched Dialog test passed in that run.