test: cover web provider scenario#827
Merged
Merged
Conversation
Size Report
Startup median (7 runs, lower is better):
Top changed chunks: no changes in the largest emitted chunks. |
817d991 to
77377d8
Compare
Member
Author
|
[P2] test/integration/provider-scenarios/web-desktop.test.ts:101 - The fake web world mutates page state on click/fill/type/scroll, but this scenario never captures or reads the page after those commands. Deleting the statusText, inputValue, or scrolled mutations in web-world.ts would still pass because the test only checks returned command data and provider-call transcripts. Issue #821 called out a stateful fake provider, and the review checklist asks what reverting snapshot state would make fail; please add a post-interaction snapshot/get assertion before screenshot/close that observes the changed status, input value, and scrolled label. |
e4e1c5a to
0dc7425
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a provider-backed web desktop scenario that exercises devices, open, snapshot, get/find/is/wait, click, fill, type, scroll, screenshot, and close through the daemon path.
Assert semantic WebProvider calls and add the minimal progress classification for web provider pressure.
Closes #821
Touched files: 5. Scope stayed within the web provider scenario path plus the router pass-through needed to inject the #819 provider seam.
Validation
Verified with direct local equivalents because the pnpm wrapper could not verify its registry signature in this environment: provider-integration web-desktop passed, integration progress check passed, TypeScript passed, and oxfmt completed.