Skip to content

feat: add semantic web provider seam#825

Merged
thymikee merged 2 commits into
mainfrom
codex/semantic-web-provider
Jun 19, 2026
Merged

feat: add semantic web provider seam#825
thymikee merged 2 commits into
mainfrom
codex/semantic-web-provider

Conversation

@thymikee

Copy link
Copy Markdown
Member

Summary

Adds the semantic web provider seam for the first web automation slice, wires request-scoped provider resolution for platform web, and routes web dispatch through a provider-backed interactor.

Closes #819

Validation

Verified with typecheck, focused provider/interactor tests, and formatting using the local pnpm binary.

@github-actions

github-actions Bot commented Jun 19, 2026

Copy link
Copy Markdown

Size Report

Metric Base Current Diff
JS raw 1.3 MB 1.3 MB +2.0 kB
JS gzip 416.2 kB 417.1 kB +954 B
npm tarball 551.0 kB 551.8 kB +792 B
npm unpacked 1.9 MB 1.9 MB +2.0 kB

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 28.5 ms 26.6 ms -1.9 ms
CLI --help 48.7 ms 44.5 ms -4.2 ms

Top changed chunks:

Chunk Raw diff Gzip diff
dist/src/9722.js +345 B +83 B

@thymikee

Copy link
Copy Markdown
Member Author

Found one blocking issue.

[P1] Wire the web provider through the request router. PlatformProviderResolvers now accepts webProvider and the descriptor installs withWebProvider, but RequestRouterDeps still has no webProvider field and createRequestHandler only forwards android/apple/linux/appLog/recording providers into withRequestPlatformProviderScope (src/daemon/request-router.ts:40, src/daemon/request-router.ts:130). As a result, real daemon requests and provider-scenario harnesses cannot supply the web provider; createWebInteractor() falls back to localWebProvider, so open/snapshot/click/fill/type/scroll on platform: web all return "Web automation requires a request-scoped web provider" even when a future adapter tries to inject one through the router. The new tests call withRequestPlatformProviderScope directly, so they do not catch this production-path gap. Please add webProvider?: WebProviderResolver to RequestRouterDeps, destructure/forward it in the provider set, and cover it with a request-router or provider-scenario test that proves a web open/snapshot reaches the injected provider through createRequestHandler.

Validation run locally: pnpm typecheck; pnpm exec vitest run src/daemon/__tests__/request-platform-providers.test.ts src/core/__tests__/web-interactor.test.ts; pnpm exec vitest run src/core/__tests__/dispatch-target.test.ts.

Base automatically changed from codex/web-platform-vocabulary to main June 19, 2026 09:56
@thymikee thymikee force-pushed the codex/semantic-web-provider branch from 817d991 to 77377d8 Compare June 19, 2026 10:01
@thymikee thymikee merged commit 833479e into main Jun 19, 2026
18 of 19 checks passed
@thymikee thymikee deleted the codex/semantic-web-provider branch June 19, 2026 10:26
@github-actions

Copy link
Copy Markdown
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-06-19 10:26 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: add semantic web provider seam

1 participant