fix: attribute Maestro iOS runner setup failures#809
Merged
Conversation
Size Report
Startup median (7 runs, lower is better):
Top changed chunks:
|
thymikee
force-pushed
the
codex/ios-maestro-runner-prewarm-failures
branch
from
e0b6dc0 to
b2be474
Compare
thymikee
changed the title
thymikee
force-pushed
the
codex/ios-maestro-runner-prewarm-failures
branch
from
b2be474 to
27a6556
Compare
thymikee
force-pushed
the
codex/ios-maestro-runner-prewarm-failures
branch
from
27a6556 to
a6d6a0c
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make Maestro iOS launch failures point at the setup step that actually failed. When an iOS Maestro
openLinkwaits for runner prewarm, runner setup errors now propagate fromopeninstead of being misreported by the following assertion.Narrow the proactive
DevToolsSecuritycheck to physical iOS devices. Simulator runs no longer require developers to enable global macOS developer mode up front; simulator runner failures are reported from the actual runner path instead.Added regression coverage at the runner-client, runner-session, open-handler, and replay-runtime layers. The branch is rebased onto current
main, which includes the integration progress-gate classification for external XCTest runner flags.Bumped the iOS prepare budget in CI and nightly workflows to
420000ms. Based on the last 30 successful iOS smoke jobs,Prepare iOS runnerhad p50 136s, p75 207s, p90 282s, p95 299s, and max 301s. The old 300s command deadline sat at the healthy p95/max edge; 420s is the next whole-minute budget above ~1.25x the observed max and gives cold Xcode 26 builds room for the follow-up health probe.Validation
pnpm test:integration:progress:checkpnpm exec vitest run src/platforms/ios/__tests__/runner-command-retry.test.ts src/platforms/ios/__tests__/runner-session.test.ts src/daemon/handlers/__tests__/session.test.ts src/daemon/handlers/__tests__/session-replay-vars.test.ts -t "prewarmIosRunnerSession can propagate|developer mode|open iOS Maestro app link reports|reports iOS Maestro openLink setup"pnpm format:checkpnpm check:quickpnpm buildpnpm check:unitoutside sandbox: 2567 unit tests and 8 smoke tests passedgit diff --checkPrepare iOS runner.tab-view-coverflow.ymlpassed with the local build before the simulator DevToolsSecurity preflight was narrowed.