Weird example in Core Libraries > Text > Text::transliterate() #8219
Merged
dereuromark merged 2 commits intocakephp:5.xfrom Feb 3, 2026
Merged
Weird example in Core Libraries > Text > Text::transliterate() #8219dereuromark merged 2 commits intocakephp:5.xfrom
dereuromark merged 2 commits intocakephp:5.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the example usages for the function
Text::transliterate(), we have the following example:Übermensch in German can refer to Superman, which might be the original intention, but it can also refer to "superior man" which can be link to either Nietzsche or the Nazis.
I believe this example should be changed to something more neutral.
I propose using größeren Apfelkuchen, which means "bigger apple pie," as it also demonstrates the capability of
transliterate()to convert ß to ss.