Rework method chaining system of Rust generator#1602
Open
QuantumSegfault wants to merge 1 commit intobytecodealliance:mainfrom
Open
Rework method chaining system of Rust generator#1602QuantumSegfault wants to merge 1 commit intobytecodealliance:mainfrom
QuantumSegfault wants to merge 1 commit intobytecodealliance:mainfrom
Conversation
Contributor
Author
|
Requesting review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #1586
After testing, #1586 had some major flaws in practice
&Self, which makes things like passing a method chain into a parameter expecting an own more cumbersome than necessary.This replaces the
--enable-method-chainingswitch with a--chainable-methodsparameter, that works similar to the current async filter. You can choose to opt-in to it for all methods, for all methods within a particular resource, or just for a particular method (or any combination of those).Additional, methods with method chaining enabled now take owning
selfinstead of the default borrowing&self, and are-> Selfrather than-> &Self. The ABI remains unaffected.