Skip to content

feat(moonbit): add map type support#1584

Queued
yordis wants to merge 1 commit intobytecodealliance:mainfrom
yordis:yordis/feat-moonbit-map-support
Queued

feat(moonbit): add map type support#1584
yordis wants to merge 1 commit intobytecodealliance:mainfrom
yordis:yordis/feat-moonbit-map-support

Conversation

@yordis
Copy link
Copy Markdown
Contributor

@yordis yordis commented Apr 11, 2026

This PR adds map type support to the MoonBit backend, following the same pattern established in #1562 (core) and #1583 (Go).

@yordis yordis force-pushed the yordis/feat-moonbit-map-support branch from a184289 to ff93aa2 Compare April 11, 2026 04:39
@alexcrichton
Copy link
Copy Markdown
Member

@peter-jerry-ye would you be up for reviewing?

@peter-jerry-ye
Copy link
Copy Markdown
Contributor

Sorry, I haven't been tracking the CM for some time and I'm a bit lost. Is there any spec on the Map type over the ABI or stuff like that? I didn't find it in WASI / Component-Model repo; and #1562 didn't seem to bring any reference to the spec. Did I miss any issue?

@yordis
Copy link
Copy Markdown
Contributor Author

yordis commented Apr 14, 2026

@peter-jerry-ye WebAssembly/component-model#554 is that what you are looking for?

@peter-jerry-ye
Copy link
Copy Markdown
Contributor

Yes, that's it! Thank you

Copy link
Copy Markdown
Contributor

@peter-jerry-ye peter-jerry-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, accept some API usage: the standard library now unifies to length

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@yordis yordis force-pushed the yordis/feat-moonbit-map-support branch from ff93aa2 to 6320c85 Compare April 14, 2026 16:09
@yordis
Copy link
Copy Markdown
Contributor Author

yordis commented Apr 14, 2026

@peter-jerry-ye done!

@alexcrichton alexcrichton enabled auto-merge April 14, 2026 16:15
@alexcrichton alexcrichton added this pull request to the merge queue Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants