Skip to content

Comments

fix(rust): Restrict equal types to the current world#1549

Draft
chenyan2002 wants to merge 1 commit intobytecodealliance:mainfrom
chenyan2002:fix-eq-types
Draft

fix(rust): Restrict equal types to the current world#1549
chenyan2002 wants to merge 1 commit intobytecodealliance:mainfrom
chenyan2002:fix-eq-types

Conversation

@chenyan2002
Copy link
Contributor

Fix #1543

  • Move name_interface to preprocess phase to avoid crashing when referring to not-yet-generated types from bindgen
  • Restrict equal types to the current world, so that bindgen doesn't refer to types not reachable from the current world

@alexcrichton
Copy link
Member

Oh sorry I didn't realize this was ready for some review. I figured draft + failing tests meant there was still some work to do locally.

These changes in general look good to me, I'm not entirely sure what would cause the test failures though. To me though it seems like it's in the right direction at least for resolving #1543 (I'd also request to be sure to include tests as well here though)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rust: bug with merge structurally equal types

2 participants