wasmtime-cache: Gate mtime in cache key on git presence, not debug_assertions#13535
Open
tomasol wants to merge 1 commit into
Open
wasmtime-cache: Gate mtime in cache key on git presence, not debug_assertions#13535tomasol wants to merge 1 commit into
tomasol wants to merge 1 commit into
Conversation
…sertions
Change the codegen cache key:
* Git builds (Wasmtime developers): cache key is `{compiler}-{sha}-{mtime}`,
so successive local rebuilds don't share cached compilations from prior
source states.
* Non-git builds (crates.io embedders): cache key is `{compiler}-{version}`,
which is stable across rebuilds and lets debug-build embedders reuse the
cache.
`debug_assertions` no longer affects the cache directory.
Also fix bug where exit status of `git rev-parse HEAD` was not checked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the codegen cache key:
{compiler}-{sha}-{mtime}, so successive local rebuilds don't share cached compilations from prior source states.{compiler}-{version}, which is stable across rebuilds and lets debug-build embedders reuse the cache.debug_assertionsno longer affects the cache directory.Also fix bug where exit status of
git rev-parse HEADwas not checked.Closes #13526