x64: Optimize some lowerings using ptest#13462
Merged
alexcrichton merged 2 commits intoMay 26, 2026
Merged
Conversation
This commit handles a few more patterns that the `ptest` instruction can be used for on x64, notably when testing `v128` values for equality. This additionally handles cases where `v128.and`'d values are used for a branch which is naturally handled by the `ptest` instruction, too. Closes bytecodealliance#13405
github-actions
Bot
added
cranelift
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit handles a few more patterns that the
ptestinstruction can be used for on x64, notably when testingv128values for equality. This additionally handles cases wherev128.and'd values are used for a branch which is naturally handled by theptestinstruction, too.Closes #13405