trap if waitable added to waitable-set while used synchronously#13415
Open
dicej wants to merge 1 commit into
Open
trap if waitable added to waitable-set while used synchronously#13415dicej wants to merge 1 commit into
dicej wants to merge 1 commit into
Conversation
github-actions
Bot
added
wasmtime:api
dicej
force-pushed
the
waitable-sync-async-trap
branch
from
3ce2474 to
67d0619
Compare
Contributor
Author
|
I realized we don't have a test yet for adding a waitable to a set while it's involved in a sync operation; will add one. |
...and vice-versa. Per WebAssembly/component-model#647, a waitable may not be added to a waitable-set while it's being used in a synchronous operation, nor may a waitable that's already added to a waitable-set be used in a synchronous operation. Test case courtesy of Alex via bytecodealliance#13212. Fixes bytecodealliance#13212
dicej
force-pushed
the
waitable-sync-async-trap
branch
from
67d0619 to
44e630a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...and vice-versa.
Per WebAssembly/component-model#647, a waitable may not be added to a waitable-set while it's being used in a synchronous operation, nor may a waitable that's already added to a waitable-set be used in a synchronous operation.
Test case courtesy of Alex via #13212.
Fixes #13212