Skip to content

add watchOS CI build target #13359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
matthargett wants to merge 11 commits into from
+20 −1
Closed

add watchOS CI build target #13359

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ec946e4
ci: add watchOS compile targets to platform_checks
claude May 12, 2026
076b18f
prtest:platform-checks
claude May 12, 2026
13542b8
ci: use cargo check for watchOS platform targets
claude May 12, 2026
b701565
ci: drop arm64_32-apple-watchos, add WATCHOS_DEPLOYMENT_TARGET
claude May 12, 2026
a63d6a6
ci: scope watchOS check to compile-only path
claude May 12, 2026
1973825
ci: restore arm64_32-apple-watchos, set WATCHOS_DEPLOYMENT_TARGET=11.0
claude May 12, 2026
81c5eba
ci: check cranelift-codegen arm64 backend for watchOS targets
claude May 12, 2026
7a44118
ci: check cranelift-codegen core for arm64_32-apple-watchos without a…
claude May 12, 2026
55aa537
ci: use cranelift-entity for arm64_32-apple-watchos check
claude May 12, 2026
ca6981f
bump iOS deployment target, less verbose comment
matthargett May 13, 2026
4538534
review feedback
matthargett May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,7 +588,21 @@ jobs:
os: macos-latest
test: cargo build
env:
IPHONEOS_DEPLOYMENT_TARGET: 13.0
IPHONEOS_DEPLOYMENT_TARGET: 16.0
# watchOS targets are Tier 3 in Rust so there is no prebuilt `std`.
# Check cranelift-codegen (no std, no mach2, no C helpers) which is
# the core thing needed for executing Wasm on Apple Watch.
# arm64_32 uses ILP32 (32-bit pointer width). cranelift-codegen has
# heavy deps (regalloc2, cranelift-assembler-x64) that may not compile
# for 32-bit pointer targets; so we only test the lighter cranelift-entity
# which still exercises wasmtime-core, entity references, and bitsets.
- target: arm64_32-apple-watchos
os: macos-latest
toolchain: wasmtime-ci-pinned-nightly
build_std: true
test: cargo check -p cranelift-entity --no-default-features -Zbuild-std=core,alloc
Copy link
Copy Markdown
Member

@alexcrichton alexcrichton May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally this would use -p wasmtime, and is the only blocker for that publishing a new target-lexicon?

Copy link
Copy Markdown
Contributor Author

@matthargett matthargett May 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so. --no-default-features sidesteps needing the mach2 update.

Copy link
Copy Markdown
Member

@alexcrichton alexcrichton May 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, in that case I think it's best to get target-lexicon published first to add the check for wasmtime here. Otherwise I suspect this probably already passed prior to your work and the real interesting portabilty target is Wasmtime itself, so the check as-is isn't buying a whole lot

env:
WATCHOS_DEPLOYMENT_TARGET: "11.0"
# Test that when Cranelift has no support for an architecture, even a
# 64-bit one, that Wasmtime still compiles. Note that this is also
# intended to test various fallbacks in the codebase where we have no
Expand All @@ -611,7 +625,12 @@ jobs:
with:
submodules: true
- uses: ./.github/actions/install-rust
with:
toolchain: ${{ matrix.toolchain || 'default' }}
- run: rustup component add rust-src
if: ${{ matrix.build_std }}
- run: rustup target add ${{ matrix.target }}
if: ${{ !matrix.build_std }}
- name: Install cross
run: |
curl -L --proto '=https' --tlsv1.2 -sSf https://raw.githubusercontent.com/cargo-bins/cargo-binstall/main/install-from-binstall-release.sh | bash
Expand Down
Loading