fix: Broken string cast in Windows GetModuleHandle{A,W} call#4923
Open
0x0ade wants to merge 1 commit intobytecodealliance:mainfrom
Open
fix: Broken string cast in Windows GetModuleHandle{A,W} call#49230x0ade wants to merge 1 commit intobytecodealliance:mainfrom
0x0ade wants to merge 1 commit intobytecodealliance:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetModuleHandlecan end up calling either the A (default chars / ANSI) or W (2-byte wide chars / UTF-16) variant, which requires its parameter to be the matching type. The current implementation interprets a 1-byte-per-char string asLPCTSTR, instead of using theTEXTmacro, which properly passes the string as either ANSI or UTF-16 (string prefixed withL), depending on theUNICODEpreprocessor definition.