Skip to content

Add NULL check in ns_lookup_list_search for DNS resolution #4844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sumleo wants to merge 1 commit into from
Closed

Add NULL check in ns_lookup_list_search for DNS resolution #4844

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions core/iwasm/libraries/libc-wasi/sandboxed-system-primitives/src/posix.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,9 @@ ns_lookup_list_search(char **list, const char *host)
{
size_t host_len = strlen(host), suffix_len;

if (!list)
Copy link
Contributor

@lum1n0us lum1n0us Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good practice on defensive programing skills.

But WAMR tends to use a caller-guarantee policy. Caller should make sure their inputs are correct. In this case, wash-app should check inputs before uses Wasm/WASI APIs.

Therefore, I tend to reject this PR.

return false;

while (*list) {
if (*list[0] == '*') {
suffix_len = strlen(*list) - 1;
Expand Down
Loading