fix(bindgen): host read on stream, determinism, expand stream tests#1291
Open
vados-cosmonic wants to merge 1 commit intobytecodealliance:mainfrom
Open
fix(bindgen): host read on stream, determinism, expand stream tests#1291vados-cosmonic wants to merge 1 commit intobytecodealliance:mainfrom
vados-cosmonic wants to merge 1 commit intobytecodealliance:mainfrom
Conversation
vados-cosmonic
force-pushed
the
fix(bindgen)=more-stream-tests
branch
from
8a1c49d to
ed8288d
Compare
This commit fixes some issues with host reads on streams to ensure that reads initiated by hosts automatically retry after being blocked, fixes some bugs that were exposed by determinism changes. This commit does not yet *fully* enumerate the types we want to test under streams, but re-enabling tests from here should be dramatically more straight forward.
vados-cosmonic
force-pushed
the
fix(bindgen)=more-stream-tests
branch
from
ed8288d to
2e46a3e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes some issues with host reads on streams to ensure that reads initiated by hosts automatically retry after being blocked, fixes some bugs that were exposed by determinism changes.
This commit does not yet fully enumerate the types we want to test under streams, but re-enabling tests from here should be dramatically more straight forward.