Add support for acquiring OpenID claims when making a token request with a UserCredentials grant#973
Conversation
…ith a UserCredentials grant
There was a problem hiding this comment.
Merry Christmas! This is a great pull request, thank you for your contribution! A few thoughts:
-
The tests are failing because
issuerneeds to be set on the server in order to use the IdToken storage in OpenId\GrantType\AuthorizationCodeTest. -
This brings up the issue of backwards compatibility.Your changes will break those who are currently using
use_openid_connectbut have not set theissuerparameter. While it's unlikely someone would be doing this, it's unfortunately possible.
Another issue is someone could update this dependency and now their token controller behaves differently than before (e.g. responding to theopenidscope) without their knowledge. So it may be best to submit this to the2.xbranch and I can push to getting a new version out. We can also submit it to themasterbranch, but use a different config parameter, e.g.use_openid_connect_token_controller -
Please add tests for the new functionality!
Thanks again, I'm excited to get this merged!
No description provided.