cleanup: pg utils#3675
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR cleans up pg’s value/array serialization utilities by de-duplicating the ArrayBufferView -> Buffer conversion logic and doing a small readability refactor in arrayString.
Changes:
- Introduces a
bufferFromhelper to centralizeArrayBuffer+ offset/length handling. - Refactors
arrayStringto use a singleitemvariable and simplify string concatenation. - Updates
prepareValueto use the newbufferFromhelper forArrayBufferViewinputs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+14
to
+18
| // Node.js v4 does not support those Buffer.from params | ||
| const bufferFrom = | ||
| Buffer.from(new Uint8Array(1).buffer, 0, 0).length === 0 | ||
| ? Buffer.from | ||
| : (arrayBuffer, byteOffset, length) => Buffer.from(arrayBuffer).slice(byteOffset, byteOffset + length) |
Owner
There was a problem hiding this comment.
hmmm p sure we don't support node v4 anymore 😛
Collaborator
Author
There was a problem hiding this comment.
Yeah. I had left it that way intentionally, but are you okay with cleanup in pg 8 dropping support for Node <16? I can push an update to this and some other things in that case.
brianc
approved these changes
May 14, 2026
Comment on lines
+14
to
+18
| // Node.js v4 does not support those Buffer.from params | ||
| const bufferFrom = | ||
| Buffer.from(new Uint8Array(1).buffer, 0, 0).length === 0 | ||
| ? Buffer.from | ||
| : (arrayBuffer, byteOffset, length) => Buffer.from(arrayBuffer).slice(byteOffset, byteOffset + length) |
Owner
There was a problem hiding this comment.
hmmm p sure we don't support node v4 anymore 😛
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.