More explicit default git settings#1972
Conversation
Ankur Goyal (ankrgyl)
changed the title
Manu Goyal (manugoyal)
left a comment
Manu Goyal (manugoyal)
left a comment
There was a problem hiding this comment.
Wondering if we really need the defaults in the SDK level too? Same applies to the python sdk
| state.proxyUrl = iso.getEnv("BRAINTRUST_PROXY_URL") ?? org.proxy_url; | ||
| state.gitMetadataSettings = org.git_metadata || undefined; | ||
| state.gitMetadataSettings = | ||
| org.git_metadata || defaultGitMetadataSettings(); |
There was a problem hiding this comment.
Do we really need to default these settings in both the SDKs and the control
plane? I worry about maintining duplicate copies of defaults across our control
plane and SDKs in case we want to revise this.
If we are always defaulting in the control plane now, maybe we can defensively
switch this to not collecting anything if the apikey/login endpoint returns
nothing?
There was a problem hiding this comment.
Manu Goyal (@manugoyal) given that this PR merged with the same behavior: braintrustdata/braintrust-sdk-python#408
Should we change that one as well or keep what's currently in this patch?
4 participants
No description provided.