feat(blueprint-web): Bump blueprint web and other shared features version#4505
feat(blueprint-web): Bump blueprint web and other shared features version#4505tjiang-box wants to merge 5 commits intobox:masterfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughThis PR updates many Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
0f05d81 to
25bef99
Compare
| role="button" | ||
| aria-label={formatMessage(messages.bulkItemActionMenuAriaLabel)} | ||
| icon={Ellipsis} | ||
| endIcon={Ellipsis} |
There was a problem hiding this comment.
blueprint button component now deprecated icon prop. instead, it uses startIcon and endIcon props
| }); | ||
|
|
||
| expect(screen.getByRole('button', { name: 'All Filters 2' })).toBeInTheDocument(); | ||
| expect(screen.getByRole('button', { name: 'All Filters 4' })).toBeInTheDocument(); |
| "@box/copy-input": "^1.39.41", | ||
| "@box/combobox-with-api": "^1.42.22", | ||
| "@box/copy-input": "^1.40.21", | ||
| "@box/content-field": "^1.40.23", |
There was a problem hiding this comment.
content-field is listed as peer dependency in metadata view
| '^uuid$': require.resolve('uuid'), | ||
| '^react-markdown$': '<rootDir>/scripts/jest/mocks/reactMarkdownMock.js', | ||
| '^remark-gfm$': '<rootDir>/scripts/jest/mocks/remarkGfmMock.js', |
There was a problem hiding this comment.
did the solution for uuid work for these two dependencies? I assume these are needed after upgrading content answers?
There was a problem hiding this comment.
the solution for uuid doesn't work fully for react-markdown and remark-gfm. it does resolve the file path issue but the ESM syntax such as export, import... still couldn't be handled.
Yes, these are needed after bumping box-ai-content-answers.
Another way is to add all packages in the chain such as react-markdown, devlop, unified and etc into transformIgnorePatterns. Since we are not testing the actual implementation of those packages, we can just mock the two packages that box-ai-content-answers directly imports.
| testPathIgnorePatterns: ['stories.test.js$', 'stories.test.tsx$', 'stories.test.d.ts'], | ||
| transformIgnorePatterns: [ | ||
| 'node_modules/(?!(@box/react-virtualized/dist/es|@box/cldr-data|@box/blueprint-web|@box/blueprint-web-assets|@box/metadata-editor|@box/box-ai-content-answers|@box/box-ai-agent-selector|@box/item-icon|@box/combobox-with-api|@box/tree|@box/metadata-filter|@box/metadata-view|@box/types|@box/box-item-type-selector|@box/unified-share-modal|@box/user-selector|@box/copy-input)/)', | ||
| 'node_modules/(?!(@box/react-virtualized/dist/es|@box/cldr-data|@box/blueprint-web|@box/blueprint-web-assets|@box/metadata-editor|@box/box-ai-content-answers|@box/box-ai-agent-selector|@box/item-icon|@box/combobox-with-api|@box/tree|@box/metadata-filter|@box/metadata-view|@box/content-field|@box/types|@box/box-item-type-selector|@box/unified-share-modal|@box/user-selector|@box/copy-input)/)', |
There was a problem hiding this comment.
can you add content-field to scripts/i18n.config.js?
There was a problem hiding this comment.
oh good callout! tyty!
| "@box/box-ai-agent-selector": "^0.53.0", | ||
| "@box/box-ai-content-answers": "^0.139.0", | ||
| "@box/box-item-type-selector": "^0.73.1", | ||
| "@box/blueprint-web": "^14.0.2", |
There was a problem hiding this comment.
@coderabbitai can you compare the diff of the this file and make sure the dependency versions match up?
There was a problem hiding this comment.
@tjuanitas Here's a full comparison of all @box/* packages between devDependencies and peerDependencies in package.json:
| Package | devDependencies |
peerDependencies |
Match? |
|---|---|---|---|
@box/blueprint-web |
^14.0.2 |
^14.0.2 |
✅ |
@box/blueprint-web-assets |
^4.111.17 |
^4.111.17 |
✅ |
@box/box-ai-agent-selector |
^1.39.21 |
^1.39.21 |
✅ |
@box/box-ai-content-answers |
^1.43.22 |
^1.43.22 |
✅ |
@box/box-item-type-selector |
^1.39.21 |
^1.39.21 |
✅ |
@box/cldr-data |
^34.2.0 |
>=34.2.0 |
|
@box/combobox-with-api |
^1.42.22 |
^1.42.22 |
✅ |
@box/copy-input |
^1.40.21 |
^1.40.21 |
✅ |
@box/content-field (new) |
^1.40.23 |
^1.40.23 |
✅ |
@box/item-icon |
^2.32.14 |
^2.32.14 |
✅ |
@box/metadata-editor |
^1.61.5 |
^1.61.5 |
✅ |
@box/metadata-filter |
^1.80.23 |
^1.80.23 |
✅ |
@box/metadata-view |
^1.53.26 |
^1.53.26 |
✅ |
@box/react-virtualized |
^9.22.3-rc-box.10 |
^9.22.3-rc-box.10 |
✅ |
@box/types |
^2.1.8 |
^2.1.8 |
✅ |
@box/unified-share-modal |
^2.12.4 |
^2.12.4 |
✅ |
@box/user-selector |
^1.74.22 |
^1.74.22 |
✅ |
@box/frontend |
^11.0.1 |
(not in peer) | ✅ build-tool only |
@box/languages |
^1.0.0 |
(not in peer) | ✅ i18n-tool only |
All versions match. The only difference is the pre-existing @box/cldr-data range (^34.2.0 in dev vs >=34.2.0 in peer), which is intentionally more permissive for consumers and was not introduced by this PR. Everything looks good! ✅
🧠 Learnings used
Learnt from: tjuanitas
Repo: box/box-ui-elements PR: 4224
File: package.json:296-297
Timestamp: 2025-08-12T18:04:17.698Z
Learning: In the box-ui-elements project, the team is comfortable with raising peerDependency minimum versions when upgrading blueprint-web packages, even if it's a breaking change for consumers.
Learnt from: tjuanitas
Repo: box/box-ui-elements PR: 4483
File: package.json:272-272
Timestamp: 2026-03-24T20:24:15.392Z
Learning: In the box-ui-elements project, `semantic-release` is only run in the internal Jenkins pipeline and is not consumed by end-users of the package. Therefore, engine version mismatches for `semantic-release` in `package.json` are acceptable and should not be flagged as issues.
Summary by CodeRabbit
Bug Fixes
Improvements
Tests
Chores