fix(deps): Bump storybook from 9.1.17 to 9.1.19#4463
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughPackage bumps for Storybook packages in Changes
Sequence Diagram(s)(omitted) Estimated Code Review Effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly Related PRs
Suggested Reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Merge Queue StatusRule:
This pull request spent 11 minutes 11 seconds in the queue, with no time running CI. Required conditions to merge
ReasonThe merge conditions cannot be satisfied due to failing checks HintYou may have to fix your CI before adding the pull request to the queue again. |
171d550
44bb986 to
171d550
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@src/elements/content-sidebar/stories/tests/MetadataSidebarRedesign-visual.stories.tsx`:
- Around line 569-571: The assertion after userEvent.click(autofillButton) can
be flaky because the autofill triggers an async API call and re-render; wrap the
post-click check in waitFor() so the test waits for canvasElement to contain
'4/1/2024' before asserting. Update the test that calls
userEvent.click(autofillButton) to use await waitFor(() =>
expect(canvasElement).toHaveTextContent('4/1/2024')) (or equivalent) so the DOM
update completes reliably.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 39a4ba30-cdc5-49d9-a22b-eeddaedc41cb
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (2)
package.jsonsrc/elements/content-sidebar/stories/tests/MetadataSidebarRedesign-visual.stories.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
- package.json
src/elements/content-sidebar/stories/tests/MetadataSidebarRedesign-visual.stories.tsx
Outdated
Show resolved
Hide resolved
171d550 to
29a2293
Compare
src/elements/content-sidebar/stories/tests/MetadataSidebarRedesign-visual.stories.tsx
Show resolved
Hide resolved
Merge Queue StatusRule:
This pull request spent 6 seconds in the queue, with no time running CI. Required conditions to merge
|
Bumps storybook from 9.1.17 to 9.1.19.
Summary by CodeRabbit