Skip to content

fix(deps): Bump storybook from 9.1.17 to 9.1.19#4463

Merged
mergify[bot] merged 2 commits intomasterfrom
bump-storybook-9.1.19
Mar 5, 2026
Merged

fix(deps): Bump storybook from 9.1.17 to 9.1.19#4463
mergify[bot] merged 2 commits intomasterfrom
bump-storybook-9.1.19

Conversation

@jfox-box
Copy link
Contributor

@jfox-box jfox-box commented Mar 4, 2026

Bumps storybook from 9.1.17 to 9.1.19.

Summary by CodeRabbit

  • Chores
    • Updated Storybook and related packages to 9.1.19; no user-facing behavior or API changes.
  • Tests
    • Improved a visual test to await an interaction and assert displayed content more reliably; no functional changes.

@jfox-box jfox-box requested a review from a team as a code owner March 4, 2026 23:10
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 4, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1e37525d-84ff-48c3-baa7-358a628dc37d

📥 Commits

Reviewing files that changed from the base of the PR and between 171d550 and 29a2293.

📒 Files selected for processing (1)
  • src/elements/content-sidebar/stories/tests/MetadataSidebarRedesign-visual.stories.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/elements/content-sidebar/stories/tests/MetadataSidebarRedesign-visual.stories.tsx

Walkthrough

Package bumps for Storybook packages in package.json and a small test update in src/elements/content-sidebar/stories/tests/MetadataSidebarRedesign-visual.stories.tsx that awaits an Autofill click and asserts date text via canvasElement. No public API or functional behavior changes.

Changes

Cohort / File(s) Summary
Dependency Updates
package.json
Bumped @storybook/addon-docs, @storybook/react-webpack5, and storybook from ^9.1.17 to ^9.1.19.
Visual test tweak
src/elements/content-sidebar/stories/tests/MetadataSidebarRedesign-visual.stories.tsx
Awaited the Autofill button click and replaced a waitFor-wrapped assertion with a direct canvasElement text assertion (toHaveTextContent('4/1/2024')).

Sequence Diagram(s)

(omitted)

Estimated Code Review Effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly Related PRs

Suggested Reviewers

  • greg-in-a-box
  • jpan-box

Poem

🐰 I hopped through lines both short and sweet,
Bumped Storybook steps and made clicks meet,
Awaited a tap, then the date shone bright,
Tiny fixes done — I’m off in flight. 🥕✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description lacks substantive content about the changes; it contains only merge process instructions and a minimal summary, missing details about what changed and why the update is needed. Add a description of the changes being made, including which dependencies are being updated and any relevant details about why the update is necessary or what improvements it brings.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and accurately summarizes the main change: bumping Storybook dependencies from version 9.1.17 to 9.1.19 across multiple packages.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bump-storybook-9.1.19

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

tjuanitas
tjuanitas previously approved these changes Mar 4, 2026
jpan-box
jpan-box previously approved these changes Mar 4, 2026
@mergify
Copy link
Contributor

mergify bot commented Mar 4, 2026

Merge Queue Status

Rule: Automatic strict merge


  • Entered queue2026-03-04 23:21 UTC
  • Checks started · in-place
  • 🚫 Left the queue2026-03-04 23:32 UTC · at 44bb986e469251fb1cb14ad3464cb17d0b745382

This pull request spent 11 minutes 11 seconds in the queue, with no time running CI.

Required conditions to merge

Reason

The merge conditions cannot be satisfied due to failing checks

Hint

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio queue comment.

tjiang-box
tjiang-box previously approved these changes Mar 4, 2026
@mergify mergify bot added dequeued and removed queued labels Mar 4, 2026
@jfox-box jfox-box dismissed stale reviews from tjiang-box, tjuanitas, and jpan-box via 171d550 March 5, 2026 19:51
@jfox-box jfox-box force-pushed the bump-storybook-9.1.19 branch from 44bb986 to 171d550 Compare March 5, 2026 19:51
@jfox-box jfox-box requested a review from a team as a code owner March 5, 2026 19:51
@mergify mergify bot removed the dequeued label Mar 5, 2026
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In
`@src/elements/content-sidebar/stories/tests/MetadataSidebarRedesign-visual.stories.tsx`:
- Around line 569-571: The assertion after userEvent.click(autofillButton) can
be flaky because the autofill triggers an async API call and re-render; wrap the
post-click check in waitFor() so the test waits for canvasElement to contain
'4/1/2024' before asserting. Update the test that calls
userEvent.click(autofillButton) to use await waitFor(() =>
expect(canvasElement).toHaveTextContent('4/1/2024')) (or equivalent) so the DOM
update completes reliably.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 39a4ba30-cdc5-49d9-a22b-eeddaedc41cb

📥 Commits

Reviewing files that changed from the base of the PR and between 44bb986 and 171d550.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (2)
  • package.json
  • src/elements/content-sidebar/stories/tests/MetadataSidebarRedesign-visual.stories.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • package.json

@jfox-box jfox-box force-pushed the bump-storybook-9.1.19 branch from 171d550 to 29a2293 Compare March 5, 2026 21:00
@mergify mergify bot added the queued label Mar 5, 2026
@mergify mergify bot merged commit df7c1af into master Mar 5, 2026
12 checks passed
@mergify mergify bot deleted the bump-storybook-9.1.19 branch March 5, 2026 21:35
@mergify
Copy link
Contributor

mergify bot commented Mar 5, 2026

Merge Queue Status

Rule: Automatic strict merge


  • Entered queue2026-03-05 21:35 UTC
  • Checks passed · in-place
  • Merged2026-03-05 21:35 UTC · at 29a22936df856310faa6ac5fc3f0159ab8647002

This pull request spent 6 seconds in the queue, with no time running CI.

Required conditions to merge

@mergify mergify bot removed the queued label Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants