Skip to content

feat(contentpreview): noop to get renderCustomPreview prop released#4459

Merged
mergify[bot] merged 1 commit intobox:masterfrom
ahorowitz123:noop_for_custom_preview_render_prop
Mar 2, 2026
Merged

feat(contentpreview): noop to get renderCustomPreview prop released#4459
mergify[bot] merged 1 commit intobox:masterfrom
ahorowitz123:noop_for_custom_preview_render_prop

Conversation

@ahorowitz123
Copy link
Contributor

@ahorowitz123 ahorowitz123 commented Mar 2, 2026 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Documentation
    • Simplified internal documentation comments to improve clarity and maintainability; no functional or behavioral changes for end users.

@ahorowitz123 ahorowitz123 requested review from a team as code owners March 2, 2026 17:44
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 2, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 140397f and fe9464f.

📒 Files selected for processing (1)
  • src/elements/content-preview/ContentPreview.js
💤 Files with no reviewable changes (1)
  • src/elements/content-preview/ContentPreview.js

Walkthrough

This PR removes one JSDoc line from ContentPreview's props documentation about Box.Preview not being loaded when renderCustomPreview is provided. No functional or exported API changes were made.

Changes

Cohort / File(s) Summary
Documentation update
src/elements/content-preview/ContentPreview.js		 Removed a JSDoc note that stated the Box.Preview library would not be loaded when renderCustomPreview is provided. No code or API changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

ready-to-merge

Suggested reviewers

  • shahzadaziz
  • Nefaris

Poem

🐰 A tiny line hops out of sight,
The docs grow lighter, snug and bright,
I nibble words with careful cheer,
A whisper gone — the meaning clear,
Hop on, small change, and spread delight! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description contains only the template's HTML comment with merge instructions, but lacks any actual implementation details or explanation of the changes. Add a clear description of the purpose of this noop change and why the renderCustomPreview prop release requires it, beyond the merge process instructions.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: a no-op modification to release the renderCustomPreview prop from the ContentPreview component.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

tjuanitas
tjuanitas previously approved these changes Mar 2, 2026
View reviewed changes
@ahorowitz123 ahorowitz123 force-pushed the noop_for_custom_preview_render_prop branch from 140397f to fe9464f Compare March 2, 2026 17:53
@mergify mergify bot added the queued label Mar 2, 2026
@mergify mergify bot merged commit c816fe9 into box:master Mar 2, 2026
8 of 9 checks passed
@mergify
Copy link
Contributor

mergify bot commented Mar 2, 2026

Merge Queue Status

Rule: Automatic strict merge

  • ✅ Entered queue — 2026-03-02 18:03 UTC
  • ✅ Checks passed · in-place
  • ✅ Merged — 2026-03-02 18:04 UTC · at fe9464f9a5db1047bd674b0a191592c7d1edf66f

This pull request spent 5 seconds in the queue, with no time running CI.

Required conditions to merge

@mergify mergify bot removed the queued label Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tjuanitas tjuanitas tjuanitas approved these changes

@jackiejou jackiejou jackiejou approved these changes

Assignees

No one assigned

Labels

ready-to-merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ahorowitz123 @tjuanitas @jackiejou