archive: use 3 timestamps, fixes #9400#9436
Merged
ThomasWaldmann merged 1 commit intoborgbackup:masterfrom Mar 4, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9436 +/- ##
=======================================
Coverage 76.52% 76.53%
=======================================
Files 85 85
Lines 14822 14809 -13
Branches 2214 2209 -5
=======================================
- Hits 11343 11334 -9
+ Misses 2802 2800 -2
+ Partials 677 675 -2 ☔ View full report in Codecov by Sentry. |
ThomasWaldmann
force-pushed
the
three-timestamps
branch
from
f1af788 to
5a8802e
Compare
time: the nominal ts, used for prune, list, sorting, ... start: operation start time (informative) end: operation end time (informative) Often, "time" is the same as "start" (normal borg create). But it can make sense to have a different "time": - borg create --timestamp=... - borg recreate --timestamp=... - borg recreate (will keep "time" as in original archive) - borg transfer (will keep "time" as in original archive) recreate and transfer produce new archives, "start" and "end" will reflect the recreate/transfer operation. Also: remove start_monotonic. start and end are just what the clock shows (including tz), so should be ok to compute duration from that, even for dst switching times.
ThomasWaldmann
force-pushed
the
three-timestamps
branch
from
5a8802e to
9b633cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
time: the nominal ts, used for prune, list, sorting, ...
start: operation start time (informative)
end: operation end time (informative)
Often, "time" is the same as "start" (normal borg create).
But it can make sense to have a different "time":
recreate and transfer produce new archives, "start" and "end" will reflect the recreate/transfer operation.
Also: remove start_monotonic. start and end are just what the clock shows (including tz), so should be ok to compute duration from that, even for dst switching times.
Checklist
master(or maintenance branch if only applicable there)toxor the relevant test subset)