🏃 add input + combined startup benchmarks#56
Open
natemoo-re wants to merge 2 commits into
Open
Conversation
commit: |
Contributor
Merging this PR will degrade performance by 37.29%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| 🆕 | WallTime | createInput |
N/A | 283 ms | N/A |
| 🆕 | WallTime | render + scan (both modules) |
N/A | 374 ms | N/A |
| 🆕 | WallTime | createTerm + createInput |
N/A | 374.5 ms | N/A |
| 👁 | Simulation | long input burst (200 bytes) |
979.3 µs | 1,265.3 µs | -22.61% |
| 👁 | Simulation | printable ASCII (single char) |
88.7 µs | 174.5 µs | -49.18% |
Comparing bench/combined (2fbe488) with main (ebaf397)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #52. Adds new startup benchmarks in
mode: walltimeto measure the full E2E perf of:createInputbootstrapcreateTerm + createInputbootstrap insidePromise.allrender + scanhitting both modulesalso sets both benchmark jobs to
codspeed-macrorunner to avoid hardware variance, which was causing quite a bit of noise