🧼 generate compact wcwidth tables#49
Open
natemoo-re wants to merge 8 commits into
Open
Conversation
commit: |
Contributor
Merging this PR will degrade performance by 10.25%
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing |
Member
Author
|
Performance regression appears to be due to different hardware being selected to run the benchmarks compared to main--debugged the logs locally. Merging this should be safe. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building on #35, reduces npm install size by ~12% (270 kB → 238 kB unpacked) via:
src/wcwidth.cimplementation borrowed fromtermbox2(~1,200 lines) with optimized tables generated bytasks/gen-wcwidth.tsclayterm.wasmfrom 152 kB → 128 kB;wcwidthdata was a significant portion of the binarygen-wcwidthtask to regenerate tables when Unicode data updates