refactor: alignment to use string literals instead of magic numbers#42
Open
dreyfus92 wants to merge 3 commits into
Open
refactor: alignment to use string literals instead of magic numbers#42dreyfus92 wants to merge 3 commits into
dreyfus92 wants to merge 3 commits into
Conversation
commit: |
natemoo-re
reviewed
May 24, 2026
| o += 4; | ||
|
|
||
| view.setUint32(o, (l.alignX ?? 0) | ((l.alignY ?? 0) << 8), true); | ||
| let alignX = l.alignX === "right" ? 1 : l.alignX === "center" ? 2 : 0; |
Member
There was a problem hiding this comment.
hmm, think we might benefit from a more generalized approach to string > enum conversion? like a typed resolveInt(property, value) util?
natemoo-re
approved these changes
May 24, 2026
Member
natemoo-re
left a comment
natemoo-re
left a comment
There was a problem hiding this comment.
Love this from a DX perspective! Think we'll need to discuss how far we want to take the idea of papering over clay's lower-level layout concepts for a flexbox-friendly audience.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #3