Skip to content

Add task link cards#1325

Open
klopez4212 wants to merge 15 commits into
kennylopez-agent-tasks-channel-uifrom
kennylopez-agent-tasks-links
Open

Add task link cards#1325
klopez4212 wants to merge 15 commits into
kennylopez-agent-tasks-channel-uifrom
kennylopez-agent-tasks-links

Conversation

@klopez4212

@klopez4212 klopez4212 commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add Buzz task deep links and task card rendering in markdown.
  • Render pasted task links as composer cards with minimum width so they do not collapse.
  • Keep automatic agent reply routing out of this slice so agent activation remains explicit.

Stack

  1. Add agent task conversation foundation #1323
  2. Add channel task surface #1324
  3. This PR
  4. Gate channel tasks experiment #1275

Snapshots

Task marker and recap

Task marker and recap

Channel Tasks tab

Channel Tasks tab

Tests

  • git diff --check origin/main..HEAD
  • cd desktop && pnpm check:file-sizes && ./node_modules/.bin/tsc --noEmit
  • cd desktop && pnpm test
  • cargo test --manifest-path desktop/src-tauri/Cargo.toml deep_link --lib

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1c259948d8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/src/features/messages/ui/MessageRow.tsx
Comment thread desktop/src/features/messages/lib/agentConversationLinkNode.tsx Outdated
@klopez4212 klopez4212 force-pushed the kennylopez-agent-tasks-channel-ui branch from b10b82b to 75accc5 Compare June 27, 2026 09:03
@klopez4212 klopez4212 force-pushed the kennylopez-agent-tasks-links branch from 1c25994 to 0b25615 Compare June 27, 2026 09:07

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0b25615c87

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/src/shared/ui/markdown.tsx Outdated
@klopez4212 klopez4212 force-pushed the kennylopez-agent-tasks-links branch from 0b25615 to 49cdaf8 Compare June 27, 2026 09:36

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 49cdaf8bd3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/src/features/agents/ui/AgentConversationScreen.tsx
@klopez4212 klopez4212 force-pushed the kennylopez-agent-tasks-links branch from 49cdaf8 to 846fab4 Compare June 27, 2026 09:44
@klopez4212 klopez4212 force-pushed the kennylopez-agent-tasks-channel-ui branch from 884400a to 0a2d7c7 Compare June 27, 2026 10:16
@klopez4212 klopez4212 force-pushed the kennylopez-agent-tasks-links branch from a99845a to a0d386a Compare June 27, 2026 10:17

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

disabled={!onOpenAgentConversation || !message}

P2 Badge Enable task rows whose source message is not cached

When a task marker is in the current history window but the original agent reply is not (for example, an old task with a recent title/summary marker, since the channel query only loads a bounded recent history window), this disables the row's Open action even though the task is listed. That leaves users unable to open the task from the Tasks tab unless they first switch back to Messages and page far enough to load the old source event; use the marker/link IDs to fetch or route to the task instead of requiring message to already be present.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@klopez4212 klopez4212 force-pushed the kennylopez-agent-tasks-channel-ui branch from 0a2d7c7 to acf6fa6 Compare June 27, 2026 10:43
@klopez4212 klopez4212 force-pushed the kennylopez-agent-tasks-links branch from 239d19e to ea173d7 Compare June 27, 2026 10:46
@klopez4212 klopez4212 force-pushed the kennylopez-agent-tasks-channel-ui branch from acf6fa6 to 070018b Compare June 27, 2026 11:01
@klopez4212 klopez4212 force-pushed the kennylopez-agent-tasks-links branch from ea173d7 to 77dc87f Compare June 27, 2026 11:03

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 77dc87f52d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/src/features/channels/useChannelPaneHandlers.ts

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4e11797f1e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/src/features/agents/ui/AgentConversationScreen.tsx
@klopez4212 klopez4212 force-pushed the kennylopez-agent-tasks-links branch from 4e11797 to ecae89c Compare June 27, 2026 12:01

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ecae89c7af

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/src/features/channels/useChannelPaneHandlers.ts
@klopez4212 klopez4212 force-pushed the kennylopez-agent-tasks-links branch from ecae89c to fcf9b01 Compare June 27, 2026 12:24

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fcf9b01e7b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/src/features/channels/ui/ChannelScreen.tsx Outdated
@klopez4212 klopez4212 force-pushed the kennylopez-agent-tasks-links branch 2 times, most recently from 3b8a337 to a153141 Compare June 27, 2026 12:41

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a15314153f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/src/features/channels/ui/ChannelPane.tsx
@klopez4212 klopez4212 force-pushed the kennylopez-agent-tasks-links branch 2 times, most recently from 541f127 to a938e93 Compare June 27, 2026 13:43

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a938e93878

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/src/features/channels/ui/ChannelPane.helpers.ts
@klopez4212 klopez4212 force-pushed the kennylopez-agent-tasks-links branch from a938e93 to 93f5716 Compare June 28, 2026 06:56
@klopez4212 klopez4212 force-pushed the kennylopez-agent-tasks-channel-ui branch 2 times, most recently from 9fde797 to 976cdb6 Compare June 28, 2026 07:24
@klopez4212 klopez4212 force-pushed the kennylopez-agent-tasks-links branch 2 times, most recently from a9c88e6 to 3ca83c3 Compare June 28, 2026 07:34
@klopez4212 klopez4212 force-pushed the kennylopez-agent-tasks-channel-ui branch from 976cdb6 to 287ecd4 Compare June 28, 2026 07:34
@klopez4212 klopez4212 force-pushed the kennylopez-agent-tasks-links branch 2 times, most recently from c1a19a4 to 08bc594 Compare June 28, 2026 08:11
@klopez4212 klopez4212 force-pushed the kennylopez-agent-tasks-channel-ui branch from 576a3d1 to f2352db Compare June 28, 2026 08:11
@klopez4212 klopez4212 force-pushed the kennylopez-agent-tasks-links branch from 08bc594 to 55e113d Compare June 28, 2026 08:13

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

onOpenAgentConversationLink,

P1 Badge Restore the task-link navigation callback

In any Markdown render, this runtime object still references onOpenAgentConversationLink, but the callback definition that used to create it was removed just above. That leaves the identifier unbound, so the desktop TypeScript build fails before task-link cards can render; recreate the callback that calls goChannel(link.channelId, { taskReplyId: link.agentReplyId }).

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

onOpenAgentConversationLink,

P1 Badge Restore task-link open callback

In any Markdown render, onOpenAgentConversationLink is now referenced in the runtime object even though the local useCallback that defined it was deleted just above this block. That leaves an unbound identifier, so the markdown component fails to compile or throws before messages can render; restore the callback that routes with goChannel(link.channelId, { taskReplyId: link.agentReplyId }) before storing it in runtimeRef.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@klopez4212 klopez4212 force-pushed the kennylopez-agent-tasks-links branch from 55e113d to 92ab0f7 Compare June 28, 2026 09:03
@klopez4212 klopez4212 force-pushed the kennylopez-agent-tasks-channel-ui branch from a9df246 to 5a87bfe Compare June 28, 2026 09:03

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6455487328

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

autoRouteAgentPubkeys: autoRoutedAgentPubkeys,
mentionPubkeys,
}),
mentionPubkeys,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve the single task agent when replying

Fresh evidence in the current code is that this handler still forwards the composer's mentionPubkeys unchanged. In a task conversation with one routeable agent, the composer says Message <agent>, but a plain follow-up has no explicit mention; useSendMessageMutation passes this list to buildReplyTags, which only emits recipient p tags from mentionPubkeys, while ACP defaults to mention-filtered subscriptions. Those replies therefore miss the agent unless the user manually @mentions it, so merge the sole routeable agent into the send mentions here.

Useful? React with 👍 / 👎.

@klopez4212 klopez4212 force-pushed the kennylopez-agent-tasks-links branch from 6455487 to 93eefcf Compare June 28, 2026 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant