Add task link cards#1325
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1c259948d8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
b10b82b to
75accc5
Compare
1c25994 to
0b25615
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0b25615c87
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
0b25615 to
49cdaf8
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 49cdaf8bd3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
49cdaf8 to
846fab4
Compare
884400a to
0a2d7c7
Compare
a99845a to
a0d386a
Compare
There was a problem hiding this comment.
💡 Codex Review
When a task marker is in the current history window but the original agent reply is not (for example, an old task with a recent title/summary marker, since the channel query only loads a bounded recent history window), this disables the row's Open action even though the task is listed. That leaves users unable to open the task from the Tasks tab unless they first switch back to Messages and page far enough to load the old source event; use the marker/link IDs to fetch or route to the task instead of requiring message to already be present.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
0a2d7c7 to
acf6fa6
Compare
239d19e to
ea173d7
Compare
acf6fa6 to
070018b
Compare
ea173d7 to
77dc87f
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 77dc87f52d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4e11797f1e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
4e11797 to
ecae89c
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ecae89c7af
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ecae89c to
fcf9b01
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fcf9b01e7b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
3b8a337 to
a153141
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a15314153f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
541f127 to
a938e93
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a938e93878
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
a938e93 to
93f5716
Compare
9fde797 to
976cdb6
Compare
a9c88e6 to
3ca83c3
Compare
976cdb6 to
287ecd4
Compare
c1a19a4 to
08bc594
Compare
576a3d1 to
f2352db
Compare
08bc594 to
55e113d
Compare
There was a problem hiding this comment.
💡 Codex Review
buzz/desktop/src/shared/ui/markdown.tsx
Line 2396 in 55e113d
In any Markdown render, this runtime object still references onOpenAgentConversationLink, but the callback definition that used to create it was removed just above. That leaves the identifier unbound, so the desktop TypeScript build fails before task-link cards can render; recreate the callback that calls goChannel(link.channelId, { taskReplyId: link.agentReplyId }).
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
buzz/desktop/src/shared/ui/markdown.tsx
Line 2396 in 55e113d
In any Markdown render, onOpenAgentConversationLink is now referenced in the runtime object even though the local useCallback that defined it was deleted just above this block. That leaves an unbound identifier, so the markdown component fails to compile or throws before messages can render; restore the callback that routes with goChannel(link.channelId, { taskReplyId: link.agentReplyId }) before storing it in runtimeRef.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
55e113d to
92ab0f7
Compare
a9df246 to
5a87bfe
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6455487328
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| autoRouteAgentPubkeys: autoRoutedAgentPubkeys, | ||
| mentionPubkeys, | ||
| }), | ||
| mentionPubkeys, |
There was a problem hiding this comment.
Preserve the single task agent when replying
Fresh evidence in the current code is that this handler still forwards the composer's mentionPubkeys unchanged. In a task conversation with one routeable agent, the composer says Message <agent>, but a plain follow-up has no explicit mention; useSendMessageMutation passes this list to buildReplyTags, which only emits recipient p tags from mentionPubkeys, while ACP defaults to mention-filtered subscriptions. Those replies therefore miss the agent unless the user manually @mentions it, so merge the sole routeable agent into the send mentions here.
Useful? React with 👍 / 👎.
6455487 to
93eefcf
Compare
Summary
Stack
Snapshots
Task marker and recap
Channel Tasks tab
Tests
git diff --check origin/main..HEADcd desktop && pnpm check:file-sizes && ./node_modules/.bin/tsc --noEmitcd desktop && pnpm testcargo test --manifest-path desktop/src-tauri/Cargo.toml deep_link --lib