Revamp new agent dialog#1201
Conversation
klopez4212
force-pushed
the
kennylopez-new-agent-modal
branch
from
558fa41 to
9efe199
Compare
klopez4212
force-pushed
the
kennylopez-agent-profile-sidebar
branch
from
37d03e8 to
309889d
Compare
klopez4212
changed the base branch from
kennylopez-agent-profile-sidebar
to
main
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9efe199544
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9587e6bb13
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
klopez4212
force-pushed
the
kennylopez-new-agent-modal
branch
from
9587e6b to
9b228b4
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9b228b4542
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6fb341bc61
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5cfe774546
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
klopez4212
force-pushed
the
kennylopez-new-agent-modal
branch
from
15e9e48 to
17b5b77
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 17b5b7749e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dbf808310d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: df6c2aea50
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
klopez4212
force-pushed
the
kennylopez-new-agent-modal
branch
from
df6c2ae to
37ef610
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 37ef610740
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d38925291a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aebc73dad5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
buzz/desktop/tests/e2e/persona-env-vars.spec.ts
Lines 259 to 261 in 1e2f5a6
Wait for dialog animations before screenshotting
The /workspace/buzz/AGENTS.md screenshot guidance makes waitForAnimations(page) mandatory before any page.screenshot() or locator.screenshot() in Playwright specs. This locator screenshot is taken right after expanding the Advanced section, which is animated in PersonaDialog via AnimatePresence/motion, so the captured PNG can be mid-transition or flaky; await the shared animation helper before capturing.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8f054f6f71
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7d614efa4f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 97150fae3d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1a93f6ec88
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4301c874f0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 93f835808a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 966021ec53
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0e0633618b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d4da55bc65
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3c6af684af
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7346d825b5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8ca5f52213
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5a97d694c7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if ( | ||
| message.includes("DATABRICKS_HOST required") || | ||
| message.includes("DATABRICKS_MODEL required") || | ||
| message.includes("BUZZ_AGENT_PROVIDER required") | ||
| ) { |
There was a problem hiding this comment.
When Buzz Agent is the default runtime in an OSS build or any environment without Databricks build defaults/provider credentials, model discovery returns config: BUZZ_AGENT_PROVIDER required; this branch suppresses that error, and the create dialog still allows Auto provider with only a runtime selected. The result is that the default “Create agent” path can submit an agent that immediately fails to spawn instead of telling the user to choose/configure an LLM provider. Surface this error or block submit until a usable provider/default is present.
Useful? React with 👍 / 👎.
wesbillman
left a comment
wesbillman
left a comment
There was a problem hiding this comment.
Amazing! I love all of this
Re-introduce resolve_effective_prompt_model_provider (runtime.rs) and resolve_persona_env (env_vars.rs) deleted from main in 826d735 ("Revamp new agent dialog #1201"). agent_config.rs and the provider deploy path in agents.rs still call these; they were added as part of the config-bridge feature and belong on this branch. Restore AgentInfoFocusedView, DiagnosticsFocusedView, and AgentInstructionsFocusedView exports in UserProfilePanelSections.tsx, and add missing optional props (canAddToChannel, isActionPending, onAddToChannel, etc.) that UserProfilePanel.tsx still imports/passes. Our branch only touched config-bridge sections of this file, not these unrelated exports — the rebase merged away the existing code. Bump file-size limits in check-file-sizes.mjs for runtime.rs (+26 lines for the re-added helper) and UserProfilePanelSections.tsx (+136 lines for the restored focused-view components). Co-authored-by: Will Pfleger <pfleger.will@gmail.com> Signed-off-by: Will Pfleger <pfleger.will@gmail.com>
Re-introduce resolve_effective_prompt_model_provider (runtime.rs) and resolve_persona_env (env_vars.rs) deleted from main in 826d735 ("Revamp new agent dialog #1201"). agent_config.rs and the provider deploy path in agents.rs still call these; they were added as part of the config-bridge feature and belong on this branch. Restore AgentInfoFocusedView, DiagnosticsFocusedView, and AgentInstructionsFocusedView exports in UserProfilePanelSections.tsx, and add missing optional props (canAddToChannel, isActionPending, onAddToChannel, etc.) that UserProfilePanel.tsx still imports/passes. Our branch only touched config-bridge sections of this file, not these unrelated exports — the rebase merged away the existing code. Bump file-size limits in check-file-sizes.mjs for runtime.rs (+26 lines for the re-added helper) and UserProfilePanelSections.tsx (+136 lines for the restored focused-view components). Co-authored-by: Will Pfleger <pfleger.will@gmail.com> Signed-off-by: Will Pfleger <pfleger.will@gmail.com>
Re-introduce resolve_effective_prompt_model_provider (runtime.rs) and resolve_persona_env (env_vars.rs) deleted from main in 826d735 ("Revamp new agent dialog #1201"). agent_config.rs and the provider deploy path in agents.rs still call these; they were added as part of the config-bridge feature and belong on this branch. Restore AgentInfoFocusedView, DiagnosticsFocusedView, and AgentInstructionsFocusedView exports in UserProfilePanelSections.tsx, and add missing optional props (canAddToChannel, isActionPending, onAddToChannel, etc.) that UserProfilePanel.tsx still imports/passes. Our branch only touched config-bridge sections of this file, not these unrelated exports — the rebase merged away the existing code. Bump file-size limits in check-file-sizes.mjs for runtime.rs (+26 lines for the re-added helper) and UserProfilePanelSections.tsx (+136 lines for the restored focused-view components). Co-authored-by: Will Pfleger <pfleger.will@gmail.com> Signed-off-by: Will Pfleger <pfleger.will@gmail.com>
OSS Buzz must stay provider/model-agnostic; Block-internal defaults belong in buzz-releases via env vars, not baked into the OSS tree. This removes the implicit Databricks fallback and the hardcoded Block-specific contamination introduced by #1201, across three layers: - buzz-agent config: resolve_provider/resolve_model no longer auto-infer Databricks. BUZZ_AGENT_PROVIDER is required; BUZZ_AGENT_MODEL wins over provider-specific env vars. - desktop build/runtime: add a generic BUZZ_BUILD_AGENT_ENV passthrough (newline-delimited KEY=VALUE). build.rs validates and emits BUZZ_DESKTOP_BUILD_AGENT_ENV; runtime.rs parses it via parse_agent_env_lines() and injects each pair onto spawned agents (user env still wins). This lets internal builds bake DATABRICKS_HOST without naming Databricks in OSS; OSS builds leave it unset and inject nothing. - persona dialog UI: delete the hardcoded Block model registry (goose-claude-*, databricks-gpt-*, etc.) sourced from squareup/goose-releases. Models now come exclusively from live discovery (usePersonaModelDiscovery -> discoverAgentModels); the only static fallback is the generic 'Default model' + freeform custom input. Drops the Databricks-default behavior. databricks_v2 remains a selectable provider option (parallel to the Rust enum), not a default. Co-authored-by: Will Pfleger <pfleger.will@gmail.com> Signed-off-by: Will Pfleger <pfleger.will@gmail.com>
OSS Buzz must stay provider/model-agnostic; Block-internal defaults belong in buzz-releases via env vars, not baked into the OSS tree. This removes the implicit Databricks fallback and the hardcoded Block-specific contamination introduced by #1201, across three layers: - buzz-agent config: resolve_provider/resolve_model no longer auto-infer Databricks. BUZZ_AGENT_PROVIDER is required; BUZZ_AGENT_MODEL wins over provider-specific env vars. - desktop build/runtime: add a generic BUZZ_BUILD_AGENT_ENV passthrough (newline-delimited KEY=VALUE). build.rs validates and emits BUZZ_DESKTOP_BUILD_AGENT_ENV; runtime.rs parses it via parse_agent_env_lines() and injects each pair onto spawned agents (user env still wins). This lets internal builds bake DATABRICKS_HOST without naming Databricks in OSS; OSS builds leave it unset and inject nothing. - persona dialog UI: delete the hardcoded Block model registry (goose-claude-*, databricks-gpt-*, etc.) sourced from squareup/goose-releases. Models now come exclusively from live discovery (usePersonaModelDiscovery -> discoverAgentModels); the only static fallback is the generic 'Default model' + freeform custom input. Drops the Databricks-default behavior. databricks_v2 remains a selectable provider option (parallel to the Rust enum), not a default. Co-authored-by: Will Pfleger <pfleger.will@gmail.com> Signed-off-by: Will Pfleger <pfleger.will@gmail.com>
2 participants
Summary
Screenshots
Default new agent dialog
Avatar menu
LLM provider and model
Validation
git diff --check origin/main...HEADgit diff --checkjust desktop-checkjust desktop-test(1216 tests)cargo test --manifest-path desktop/src-tauri/Cargo.toml model(15 tests)cargo test --manifest-path desktop/src-tauri/Cargo.toml agent_models(6 tests)just desktop-buildcd desktop && pnpm exec playwright test --project=integration tests/e2e/persona-env-vars.spec.ts(5 tests)desktop-test,rust-tests,mobile-test,desktop-tauri-testshasum -a 256 desktop/test-results/pr-1201-screenshots/*.png