fix(doctor): improve shell path resolution

[kalvinnchau]

Summary

• fix doctor binary resolution to avoid treating zsh function/alias output as executable paths.
• replace login-shell which with path-only shell lookup: whence -p for zsh and type -P for bash.
• validate resolved candidates as absolute executable files before using them.
• apply the same resolver hardening to shared acp-client and blox-cli command discovery.
• simplify resolver control flow and add focused tests for invalid shell output.

i have git mapped to a function that does some cleanup, but a minimal repro:

git() {
  echo "hi"
  command git "$@"
}

Testing

• cargo fmt -p doctor -p acp-client -p blox-cli
• cargo test -p doctor -p acp-client -p blox-cli

[wesbillman]

@codex please review

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5eaf5c7905

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".