Skip to content

refactor BWS server support methods#4148

Open
tmcollins4 wants to merge 1 commit intobitpay:masterfrom
tmcollins4:bws-organize-server-support
Open

refactor BWS server support methods#4148
tmcollins4 wants to merge 1 commit intobitpay:masterfrom
tmcollins4:bws-organize-server-support

Conversation

@tmcollins4
Copy link
Copy Markdown
Contributor

Description

Refactors WalletService server-support methods out of the large server.ts file into focused helper modules.

Changelog

  • Move advertisement helpers into server/advertisements.ts.
  • Move auth/session/version helpers into server/auth.ts.
  • Move logging helpers into server/logging.ts.
  • Move Moralis helper methods into server/moralis.ts.
  • Move tx note helpers into server/notes.ts.
  • Move notification subscription helpers into server/notifications.ts.
  • Move fiat/service config/cache helpers into server/services.ts.
  • Move upgrade-check constants and logic into server/shared.ts and server/upgrade.ts.
  • Keep WalletService public methods as delegating wrappers to preserve the existing API.

Testing Notes

  • Ran BWS lint and production build.
  • Ran the full BWS test suite.
  • Ran BWC lint and test suite.

Checklist

  • I have read CONTRIBUTING.md and verified that this PR follows the guidelines and requirements outlined in it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant