Remove lodash from bitcore-p2p#4147
Open
MichaelAJay wants to merge 56 commits intobitpay:masterfrom
Open
Conversation
MichaelAJay
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove lodash (imported from bitcore-lib) from bitcore-p2p. All strict
undefinedchecks (_.isUndefined(x)) were transitioned to looser nullish checks:x == null.Changelog
The following message paths were exercised on BTC and BCH. The code is similar on Doge, but not exercised.
The following message paths were not exercised:
Testing Notes
Use bitcore-cli to exercise the following:
--command address(fund externally)--command status--command balance --showByAddress--command history--command utxos--command transaction --to <dest> --amount <amt>Checklist