Conversation
sunkup
added
the
pr-bugfix
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts ORGANIZER mapping when generating iCalendar VEVENTs from Android calendar provider rows, specifically to keep exception instances aligned with their recurring main event’s ORGANIZER.
Changes:
- Update
OrganizerHandlerto base attendee/group-scheduling detection on the main event (to ensure exceptions inherit ORGANIZER even if they have no attendees). - Add tests covering ORGANIZER inheritance for exceptions and absence of ORGANIZER for non-group-scheduled events.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
lib/src/main/kotlin/at/bitfire/synctools/mapping/calendar/handler/OrganizerHandler.kt |
Changes attendee detection logic used to decide whether to emit ORGANIZER. |
lib/src/test/kotlin/at/bitfire/synctools/mapping/calendar/handler/OrganizerHandlerTest.kt |
Adds regression tests for ORGANIZER handling on exceptions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sunkup
force-pushed
the
271-put-fails-caldavsame-organizer-in-all-components-because-icalendar-contains-different-organizer-values-in-components
branch
from
17dc283 to
206d37b
Compare
rfc2822
reviewed
Apr 20, 2026
rfc2822
approved these changes
Apr 20, 2026
sunkup
force-pushed
the
271-put-fails-caldavsame-organizer-in-all-components-because-icalendar-contains-different-organizer-values-in-components
branch
3 times, most recently
from
d3dee5b to
1ce96b4
Compare
rfc2822
requested changes
Apr 20, 2026
Member
rfc2822
left a comment
rfc2822
left a comment
There was a problem hiding this comment.
I think this won't work, we had it like this before 2020 and changed it in bitfireAT/ical4android@80b9945.
See for instance the comment here:
We should have a note that documents the problem in this PR, maybe the same comment:
ORGANIZER must only be set for group-scheduled events (= events with attendees
sunkup
force-pushed
the
271-put-fails-caldavsame-organizer-in-all-components-because-icalendar-contains-different-organizer-values-in-components
branch
from
1ce96b4 to
9432a58
Compare
sunkup
deleted the
271-put-fails-caldavsame-organizer-in-all-components-because-icalendar-contains-different-organizer-values-in-components
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ORGANIZER must be the same value for all participating components - main event and its exceptions.
OrganizerHandler: Also check whether main event has attendees instead of only checking for exception attendees to decide on whether we should add ORGANIZER to the necessarily group-scheduled event.