Apply stability fix to TLruTickCount64PolicyTests.UpdateUpdatesTickCount#763
Merged
Apply stability fix to TLruTickCount64PolicyTests.UpdateUpdatesTickCount#763
Conversation
Agent-Logs-Url: https://github.com/bitfaster/BitFaster.Caching/sessions/139b02f0-2c99-4d9f-9495-1fc77746e2f3 Co-authored-by: bitfaster <12851828+bitfaster@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
bitfaster
April 14, 2026 03:03
View session
|
coverage: 99.048% (-0.05%) from 99.093% — copilot/fix-tlru-tick-count-update into main |
bitfaster
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Applies the same stability fix from #759 to
TLruTickCount64PolicyTests.UpdateUpdatesTickCount.The previous implementation used a bare
Task.Delay(1ms)which is unreliable on fast machines — the tick count may not advance in 1ms, causing the test to flake. The fix replaces it with a spin-wait loop that pollsDuration.SinceEpoch().rawuntil it advances past the creation tick count (with a 1-second timeout), matching the pattern established in #759.Changes
BitFaster.Caching.UnitTests/Lru/TLruTickCount64PolicyTests.cs: replacedawait Task.Delay(1ms)with a bounded spin-wait loop inUpdateUpdatesTickCount