Skip to content

Stabilize DiscretePolicy touch tick count test #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bitfaster merged 7 commits into from
Apr 13, 2026
+15 −3
Merged

Stabilize DiscretePolicy touch tick count test #759

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
818cb42
Stabilize discrete policy touch tick test
Copilot Apr 13, 2026
3561802
Fix discrete policy polling baseline
Copilot Apr 13, 2026
33ccd95
Assert tick source advances before touch
Copilot Apr 13, 2026
bbe3cf8
Rename discrete policy touch test
Copilot Apr 13, 2026
bc1d17f
cleanup
Apr 13, 2026
5daeb96
Merge branch 'main' into copilot/update-stable-touch-updates-test
bitfaster Apr 13, 2026
8445c43
Merge branch 'main' into copilot/update-stable-touch-updates-test
bitfaster Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions BitFaster.Caching.UnitTests/Lru/DiscretePolicyTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using System;
using System.Threading;
using System.Threading.Tasks;
using BitFaster.Caching.Lru;
using BitFaster.Caching.UnitTests.Retry;
Expand Down Expand Up @@ -68,9 +69,15 @@ public async Task TouchUpdatesTicksCount()
{
var item = this.policy.CreateItem(1, 2);
var tc = item.TickCount;
await Task.Delay(TimeSpan.FromMilliseconds(1));

this.policy.ShouldDiscard(item); // set the time in the policy
var createdAt = tc - TestExpiryCalculator<int, int>.DefaultTimeToExpire.raw;
var timeout = DateTime.UtcNow.AddSeconds(1);
while (Duration.SinceEpoch().raw == createdAt && DateTime.UtcNow < timeout)
{
await Task.Delay(TimeSpan.FromMilliseconds(1));
}

this.policy.ShouldDiscard(item); // advance time
this.policy.Touch(item);

item.TickCount.Should().BeGreaterThan(tc);
Expand All @@ -82,7 +89,12 @@ public async Task UpdateUpdatesTickCount()
var item = this.policy.CreateItem(1, 2);
var tc = item.TickCount;

await Task.Delay(TimeSpan.FromMilliseconds(20));
var createdAt = item.TickCount - TestExpiryCalculator<int, int>.DefaultTimeToExpire.raw;
var timeout = DateTime.UtcNow.AddSeconds(1);
while (Duration.SinceEpoch().raw == createdAt && DateTime.UtcNow < timeout)
{
await Task.Delay(TimeSpan.FromMilliseconds(20));
}

this.policy.Update(item);

Expand Down
Loading