Skip to content

Bump coverlet.msbuild from 6.0.4 to 8.0.1#745

Open
dependabot[bot] wants to merge 7 commits intomainfrom
dependabot/nuget/BitFaster.Caching.UnitTests.Std/multi-669b2fecb3
Open

Bump coverlet.msbuild from 6.0.4 to 8.0.1#745
dependabot[bot] wants to merge 7 commits intomainfrom
dependabot/nuget/BitFaster.Caching.UnitTests.Std/multi-669b2fecb3

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot bot commented on behalf of github Mar 30, 2026

Updated coverlet.msbuild from 6.0.4 to 8.0.1.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.



✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

---
updated-dependencies:
- dependency-name: coverlet.msbuild
  dependency-version: 8.0.1
  dependency-type: direct:production
  update-type: version-update:semver-major
- dependency-name: coverlet.msbuild
  dependency-version: 8.0.1
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added .NET Pull requests that update .NET code dependencies Pull requests that update a dependency file labels Mar 30, 2026
@bitfaster
Copy link
Copy Markdown
Owner

@copilot add .NET 8 set up to the gate.yml github workflow file that runs the build on check in. This will fix the runtime test issue.

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 30, 2026

@copilot add .NET 8 set up to the gate.yml github workflow file that runs the build on check in. This will fix the runtime test issue.

Added a net8.0 matrix entry to gate.yml in commit 016c991. This runs the tests on Windows with .NET 8.0, with coverage enabled, matching the pattern of the existing net9.0 entry.

Copilot AI requested a review from bitfaster March 30, 2026 07:15
@bitfaster
Copy link
Copy Markdown
Owner

@copilot revert the last commit you made, suggestion implemented did not work.

Agent-Logs-Url: https://github.com/bitfaster/BitFaster.Caching/sessions/9d4c56c3-17b8-41e2-8aa5-a8a9cc9f40d9

Co-authored-by: bitfaster <12851828+bitfaster@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 30, 2026

@copilot revert the last commit you made, suggestion implemented did not work.

Reverted in commit 5aca83f. The gate.yml is back to its state before the net8.0 matrix entry was added.

@bitfaster
Copy link
Copy Markdown
Owner

@copilot work on this PR to fix the build

coverlet.msbuild 8.0.1 instruments assemblies with code that requires
System.Runtime 8.0.0.0. Running tests against netcoreapp3.1 or net6.0
fails with FileNotFoundException at runtime. Disable coverage collection
for these frameworks; coverage still runs on net9.0.

Agent-Logs-Url: https://github.com/bitfaster/BitFaster.Caching/sessions/de1b570d-4a65-4b8d-b1c7-068da8ecfab0

Co-authored-by: bitfaster <12851828+bitfaster@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 12, 2026

@copilot work on this PR to fix the build

Fixed in commit 3b79ba5.

The root cause: coverlet.msbuild 8.0.1 instruments assemblies with code that references System.Runtime, Version=8.0.0.0. When tests run against netcoreapp3.1 or net6.0, the .NET 8 assembly can't be found at runtime, causing a FileNotFoundException.

The fix disables coverage collection (coverage: false) for all pre-.NET 8 matrix entries (netcoreapp3.1 and all net6.0 entries). Tests still run on those frameworks — only coverage collection is disabled. Coverage continues to run on net9.0.

@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 97.527% (-1.5%) from 99.004% — dependabot/nuget/BitFaster.Caching.UnitTests.Std/multi-669b2fecb3 into main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file .NET Pull requests that update .NET code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants