Skip to content

chain 0.23.x: forward confirmation_height_upper_bound in Anchor implementation for &A#2149

Merged
evanlinjin merged 1 commit intobitcoindevkit:release/chain-0.23.xfrom
evanlinjin:fix/chain-0.23.x-forward-confirmation-height-upper-bound-anchor
Mar 12, 2026
Merged

chain 0.23.x: forward confirmation_height_upper_bound in Anchor implementation for &A#2149
evanlinjin merged 1 commit intobitcoindevkit:release/chain-0.23.xfrom
evanlinjin:fix/chain-0.23.x-forward-confirmation-height-upper-bound-anchor

Conversation

@evanlinjin
Copy link
Member

Description

Backport of #2120
Depends on #2148

The blanket Anchor impl for &A was missing the confirmation_height_upper_bound method, causing it to fall back to the default implementation instead of delegating to the inner type.

Changelog notice

Fixed:

- The `Anchor::confirmation_height_upper_bound` impl was missing for `&A`, causing it to fallback to the default impl.

Checklists

All Submissions:

@evanlinjin evanlinjin added this to the Chain 0.23.3 milestone Mar 11, 2026
@evanlinjin evanlinjin self-assigned this Mar 11, 2026
@evanlinjin evanlinjin moved this to Needs Review in BDK Chain Mar 11, 2026
@evanlinjin evanlinjin added the backport A bug fix or security patch to be ported to a previous release label Mar 11, 2026
…l for `&A`

The blanket `Anchor` impl for `&A` was missing the
`confirmation_height_upper_bound` method, causing it to fall back to
the default implementation instead of delegating to the inner type.
@oleonardolima oleonardolima force-pushed the fix/chain-0.23.x-forward-confirmation-height-upper-bound-anchor branch from a9f3e8b to 00d7f62 Compare March 11, 2026 17:15
Copy link
Member

@luisschwab luisschwab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 00d7f62

Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 00d7f62

@evanlinjin evanlinjin merged commit 2e4ff71 into bitcoindevkit:release/chain-0.23.x Mar 12, 2026
17 of 18 checks passed
@github-project-automation github-project-automation bot moved this from Needs Review to Done in BDK Chain Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport A bug fix or security patch to be ported to a previous release

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants