chain 0.23.x: Fix ChainPosition ordering#2146
Merged
evanlinjin merged 2 commits intobitcoindevkit:release/chain-0.23.xfrom Mar 12, 2026
Merged
Conversation
ChainPosition orderingbdk_chain v0.23.x: Fix ChainPosition ordering
bdk_chain v0.23.x: Fix ChainPosition orderingchain 0.23.x: Fix ChainPosition ordering
7b45aa9 to
8e386a3
Compare
8e386a3 to
c3e960f
Compare
notmandatory
approved these changes
Mar 12, 2026
Member
notmandatory
left a comment
There was a problem hiding this comment.
ACK c3e960f
I ran it through the LLM 🤖 reviewer also and its only comments were about missing edge case tests with invalid ChainPosition data. But preventing invalid data should already be covered in other tests.
…play Previously, unconfirmed transactions never seen in mempool would appear before those with mempool timestamps due to derived Ord implementation. Changes: - Manual Ord impl: confirmed < unconfirmed < never-in-mempool - At same height: transitive confirmations < direct (potentially earlier) - Simplify FullTxOut ordering to only essential fields - Add comprehensive tests and documentation - Update CanonicalTx and FullTxOut to use manual Ord with A: Ord bound
c3e960f to
aff800d
Compare
3ef748f
into
bitcoindevkit:release/chain-0.23.x
19 checks passed
This was referenced Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Back-ported from #2074
Depends on #2148
This PR fixes incorrect ordering of
ChainPositionthat affected how wallet transactions are displayed. Previously, unconfirmed transactions that were never seen in the mempool would incorrectly appear before transactions with mempool timestamps due to the derivedOrdimplementation treatingNoneas less thanSome(_).Problem
The derived
Ordimplementation forChainPosition::Unconfirmedcaused incorrect transaction ordering:Unconfirmed { first_seen: None, last_seen: None }(never in mempool)Unconfirmed { first_seen: Some(10), last_seen: Some(10) }(seen in mempool)This resulted in a confusing wallet display where transactions never broadcast would appear before pending mempool transactions.
Solution
Implemented manual
OrdandPartialOrdtraits forChainPositionwith the correct ordering:first_seen)Additional ordering rules:
Changelog notice
Checklists
All Submissions:
Bugfixes: